Sign upLogin

mongodb/mongo-ruby-driver

View on GitHub
Star
lib/mongo/retryable/read_worker.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method legacy_read_with_retry has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

      def legacy_read_with_retry(session, server_selector, &block)
        attempt = attempt ? attempt + 1 : 1
        yield select_server(cluster, server_selector, session)
      rescue *retryable_exceptions, Error::OperationFailure, Error::PoolError => e
        e.add_notes('legacy retry', "attempt #{attempt}")
Severity: Minor
Found in lib/mongo/retryable/read_worker.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method modern_read_with_retry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def modern_read_with_retry(session, server_selector, &block)
        server = select_server(cluster, server_selector, session)
        yield server
      rescue *retryable_exceptions, Error::OperationFailure, Auth::Unauthorized, Error::PoolError => e
        e.add_notes('modern retry', 'attempt 1')
Severity: Minor
Found in lib/mongo/retryable/read_worker.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status