mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/server/description.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Description has 48 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Description

      # Constant for reading arbiter info from config.
      #
      # @since 2.0.0
Severity: Minor
Found in lib/mongo/server/description.rb - About 6 hrs to fix

    File description.rb has 294 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Mongo
      class Server
    
        # Represents a description of the server, populated by the result of the
        # hello command.
    Severity: Minor
    Found in lib/mongo/server/description.rb - About 3 hrs to fix

      Method initialize has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

            def initialize(address, config = {}, average_round_trip_time: nil,
              load_balancer: false, force_load_balancer: false
            )
              @address = address
              @config = config
      Severity: Minor
      Found in lib/mongo/server/description.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method server_version_gte? has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def server_version_gte?(version)
              required_wv = case version
                when '5.2'
                  15
                when '5.1'
      Severity: Minor
      Found in lib/mongo/server/description.rb - About 1 hr to fix

        Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def initialize(address, config = {}, average_round_trip_time: nil,
                load_balancer: false, force_load_balancer: false
              )
                @address = address
                @config = config
        Severity: Minor
        Found in lib/mongo/server/description.rb - About 1 hr to fix

          Method server_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def server_type
                  return :load_balancer if load_balancer?
                  return :arbiter if arbiter?
                  return :ghost if ghost?
                  return :sharded if mongos?
          Severity: Minor
          Found in lib/mongo/server/description.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return :secondary if secondary?
          Severity: Major
          Found in lib/mongo/server/description.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return :other if other?
            Severity: Major
            Found in lib/mongo/server/description.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return :standalone if standalone?
              Severity: Major
              Found in lib/mongo/server/description.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return :primary if primary?
                Severity: Major
                Found in lib/mongo/server/description.rb - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status