mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/server/pending_connection.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method handshake_and_authenticate! has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def handshake_and_authenticate!
        speculative_auth_doc = nil
        if options[:user] || options[:auth_mech]
          # To create an Auth instance, we need to specify the mechanism,
          # but at this point we don't know the mechanism that ultimately
Severity: Minor
Found in lib/mongo/server/pending_connection.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handshake_and_authenticate! has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def handshake_and_authenticate!
        speculative_auth_doc = nil
        if options[:user] || options[:auth_mech]
          # To create an Auth instance, we need to specify the mechanism,
          # but at this point we don't know the mechanism that ultimately
Severity: Minor
Found in lib/mongo/server/pending_connection.rb - About 1 hr to fix

    Method handshake! has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def handshake!(speculative_auth_doc: nil)
            unless socket
              raise Error::InternalDriverError, "Cannot handshake because there is no usable socket (for #{address})"
            end
    
    
    Severity: Minor
    Found in lib/mongo/server/pending_connection.rb - About 1 hr to fix

      Method default_mechanism has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def default_mechanism
              if description.nil?
                raise Mongo::Error, 'Trying to query default mechanism when handshake has not completed'
              end
      
      
      Severity: Minor
      Found in lib/mongo/server/pending_connection.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handshake! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def handshake!(speculative_auth_doc: nil)
              unless socket
                raise Error::InternalDriverError, "Cannot handshake because there is no usable socket (for #{address})"
              end
      
      
      Severity: Minor
      Found in lib/mongo/server/pending_connection.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  rescue => exc
                    msg = "Failed to authenticate to #{address}"
                    Utils.warn_bg_exception(msg, exc,
                      logger: options[:logger],
                      log_prefix: options[:log_prefix],
      Severity: Minor
      Found in lib/mongo/server/pending_connection.rb and 2 other locations - About 15 mins to fix
      lib/mongo/server/monitor/connection.rb on lines 213..221
      lib/mongo/server/pending_connection.rb on lines 143..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                rescue => exc
                  msg = "Failed to handshake with #{address}"
                  Utils.warn_bg_exception(msg, exc,
                    logger: options[:logger],
                    log_prefix: options[:log_prefix],
      Severity: Minor
      Found in lib/mongo/server/pending_connection.rb and 2 other locations - About 15 mins to fix
      lib/mongo/server/monitor/connection.rb on lines 213..221
      lib/mongo/server/pending_connection.rb on lines 187..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status