mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/session.rb

Summary

Maintainability
F
5 days
Test Coverage

File session.rb has 483 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mongo/session/session_pool'
require 'mongo/session/server_session'

module Mongo

Severity: Minor
Found in lib/mongo/session.rb - About 7 hrs to fix

    Method with_transaction has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

        def with_transaction(options=nil)
          # Non-configurable 120 second timeout for the entire operation
          deadline = Time.now + 120
          transaction_in_progress = false
          loop do
    Severity: Minor
    Found in lib/mongo/session.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Session has 44 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Session
        extend Forwardable
        include Retryable
        include Loggable
        include ClusterTime::Consumer
    Severity: Minor
    Found in lib/mongo/session.rb - About 6 hrs to fix

      Method add_txn_opts! has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          def add_txn_opts!(command, read)
            command.tap do |c|
              # The read concern should be added to any command that starts a transaction.
              if starting_transaction?
                # https://jira.mongodb.org/browse/SPEC-1161: transaction's
      Severity: Minor
      Found in lib/mongo/session.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method with_transaction has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def with_transaction(options=nil)
            # Non-configurable 120 second timeout for the entire operation
            deadline = Time.now + 120
            transaction_in_progress = false
            loop do
      Severity: Major
      Found in lib/mongo/session.rb - About 3 hrs to fix

        Method commit_transaction has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            def commit_transaction(options=nil)
              check_if_ended!
              check_if_no_transaction!
        
              if within_states?(TRANSACTION_ABORTED_STATE)
        Severity: Minor
        Found in lib/mongo/session.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method commit_transaction has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def commit_transaction(options=nil)
              check_if_ended!
              check_if_no_transaction!
        
              if within_states?(TRANSACTION_ABORTED_STATE)
        Severity: Minor
        Found in lib/mongo/session.rb - About 1 hr to fix

          Method add_txn_opts! has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def add_txn_opts!(command, read)
                command.tap do |c|
                  # The read concern should be added to any command that starts a transaction.
                  if starting_transaction?
                    # https://jira.mongodb.org/browse/SPEC-1161: transaction's
          Severity: Minor
          Found in lib/mongo/session.rb - About 1 hr to fix

            Method abort_transaction has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def abort_transaction
                  check_if_ended!
                  check_if_no_transaction!
            
                  if within_states?(TRANSACTION_COMMITTED_STATE)
            Severity: Minor
            Found in lib/mongo/session.rb - About 1 hr to fix

              Method suppress_read_write_concern! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  def suppress_read_write_concern!(command)
                    command.tap do |c|
                      next unless in_transaction?
              
                      c.delete(:readConcern) unless starting_transaction?
              Severity: Minor
              Found in lib/mongo/session.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method start_transaction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def start_transaction(options = nil)
                    if options
                      Lint.validate_read_concern_option(options[:read_concern])
              
              =begin
              Severity: Minor
              Found in lib/mongo/session.rb - About 1 hr to fix

                Method process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def process(result)
                      unless implicit?
                        set_operation_time(result)
                        if cluster_time_doc = result.cluster_time
                          advance_cluster_time(cluster_time_doc)
                Severity: Minor
                Found in lib/mongo/session.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method end_session has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def end_session
                      if !ended? && @client
                        if within_states?(TRANSACTION_IN_PROGRESS_STATE)
                          begin
                            abort_transaction
                Severity: Minor
                Found in lib/mongo/session.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method validate_read_preference! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def validate_read_preference!(command)
                      return unless in_transaction?
                      return unless command['$readPreference']
                
                      mode = command['$readPreference']['mode'] || command['$readPreference'][:mode]
                Severity: Minor
                Found in lib/mongo/session.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status