mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/socket.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method read_from_socket has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def read_from_socket(length)
      # Just in case
      if length == 0
        return ''.force_encoding('BINARY')
      end
Severity: Minor
Found in lib/mongo/socket.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read_from_socket has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def read_from_socket(length)
      # Just in case
      if length == 0
        return ''.force_encoding('BINARY')
      end
Severity: Minor
Found in lib/mongo/socket.rb - About 1 hr to fix

    Method read has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def read(length)
          handle_errors do
            data = read_from_socket(length)
            unless (data.length > 0 || length == 0)
              raise IOError, "Expected to read > 0 bytes but read 0 bytes"
    Severity: Minor
    Found in lib/mongo/socket.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status