mongodb/mongo-ruby-driver

View on GitHub
lib/mongo/uri.rb

Summary

Maintainability
D
2 days
Test Coverage

File uri.rb has 435 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Mongo

  # The URI class provides a way for users to parse the MongoDB uri as
  # defined in the connection string format spec.
  #
Severity: Minor
Found in lib/mongo/uri.rb - About 6 hrs to fix

    Class URI has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class URI
        include Loggable
    
        # The uri parser object options.
        #
    Severity: Minor
    Found in lib/mongo/uri.rb - About 5 hrs to fix

      Method initialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(string, options = {})
            @string = string
            @options = options
            parsed_scheme, _, remaining = string.partition(SCHEME_DELIM)
            raise_invalid_error!(INVALID_SCHEME) unless parsed_scheme == scheme
      Severity: Minor
      Found in lib/mongo/uri.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse! has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse!(remaining)
            hosts_and_db, options = remaining.split('?', 2)
            if options && options.index('?')
              raise_invalid_error!("Options contain an unescaped question mark (?), or the database name contains a question mark and was not escaped")
            end
      Severity: Minor
      Found in lib/mongo/uri.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse! has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def parse!(remaining)
            hosts_and_db, options = remaining.split('?', 2)
            if options && options.index('?')
              raise_invalid_error!("Options contain an unescaped question mark (?), or the database name contains a question mark and was not escaped")
            end
      Severity: Minor
      Found in lib/mongo/uri.rb - About 1 hr to fix

        Method parse_password! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def parse_password!(string)
              if (string && pwd = string.partition(AUTH_USER_PWD_DELIM)[2])
                if pwd.length > 0
                  raise_invalid_error!(UNESCAPED_USER_PWD) if pwd =~ UNSAFE
                  pwd_decoded = decode(pwd)
        Severity: Minor
        Found in lib/mongo/uri.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_user! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def parse_user!(string)
              if (string && user = string.partition(AUTH_USER_PWD_DELIM)[0])
                if user.length > 0
                  raise_invalid_error!(UNESCAPED_USER_PWD) if user =~ UNSAFE
                  user_decoded = decode(user)
        Severity: Minor
        Found in lib/mongo/uri.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_uri_options! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def parse_uri_options!(string)
              uri_options = {}
              unless string
                return uri_options
              end
        Severity: Minor
        Found in lib/mongo/uri.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate_host! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def validate_host!(host)
              case host
              when /\A\[[\d:]+\](?::(\d+))?\z/
                # ipv6 with optional port
                if port_str = $1
        Severity: Minor
        Found in lib/mongo/uri.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method max_staleness has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def max_staleness(value)
              if /\A-?\d+\z/ =~ value
                int = value.to_i
        
                if int == -1
        Severity: Minor
        Found in lib/mongo/uri.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def parse_password!(string)
              if (string && pwd = string.partition(AUTH_USER_PWD_DELIM)[2])
                if pwd.length > 0
                  raise_invalid_error!(UNESCAPED_USER_PWD) if pwd =~ UNSAFE
                  pwd_decoded = decode(pwd)
        Severity: Minor
        Found in lib/mongo/uri.rb and 1 other location - About 40 mins to fix
        lib/mongo/uri.rb on lines 406..416

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def parse_user!(string)
              if (string && user = string.partition(AUTH_USER_PWD_DELIM)[0])
                if user.length > 0
                  raise_invalid_error!(UNESCAPED_USER_PWD) if user =~ UNSAFE
                  user_decoded = decode(user)
        Severity: Minor
        Found in lib/mongo/uri.rb and 1 other location - About 40 mins to fix
        lib/mongo/uri.rb on lines 419..429

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status