Sign upLogin

mongodb/mongoid

View on GitHub
Star
lib/mongoid/fields/foreign_key.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method mongoize_foreign_key has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def mongoize_foreign_key(object)
        if type == Array || type == Set
          object = object.to_a if type == Set || object.is_a?(Set)

          if object.resizable?
Severity: Minor
Found in lib/mongoid/fields/foreign_key.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_atomic_changes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def add_atomic_changes(document, name, key, mods, new_elements, old_elements)
        old = (old_elements || [])
        new = (new_elements || [])
        if new.length > old.length
          if new.first(old.length) == old
Severity: Minor
Found in lib/mongoid/fields/foreign_key.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_atomic_changes has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def add_atomic_changes(document, name, key, mods, new_elements, old_elements)
Severity: Minor
Found in lib/mongoid/fields/foreign_key.rb - About 45 mins to fix

    Method evolve has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def evolve(object)
        if object_id_field? || object.is_a?(Document)
          if association.polymorphic?
            association.convert_to_foreign_key(object)
          elsif object.is_a?(Document) && object.respond_to?(association.primary_key)
    Severity: Minor
    Found in lib/mongoid/fields/foreign_key.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status