Sign upLogin

mongoid/mongoid-cached-json

View on GitHub
Star

Showing 11 of 11 total issues

Method resolve_json_reference has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

      def resolve_json_reference(options, object, _field, reference_def)
        keys = nil
        reference_json = nil
        if reference_def[:metadata]
          key = reference_def[:metadata].key.to_sym
Severity: Minor
Found in lib/mongoid-cached-json/cached_json.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method materialize_json has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

      def materialize_json(options, object_def)
        return nil if !object_def[:object] && !object_def[:id]
        is_top_level_json = options[:is_top_level_json] || false
        if object_def[:object]
          object_reference = object_def[:object]
Severity: Minor
Found in lib/mongoid-cached-json/cached_json.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method materialize_json_references has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def self.materialize_json_references(key_refs, local_cache = {}, read_multi = false)
      key_refs.each_pair do |key, refs|
        refs.each do |ref|
          _ref = ref.delete(:_ref)
          key = _ref[:_key]
Severity: Minor
Found in lib/mongoid-cached-json/cached_json.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method materialize_cached_json has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def materialize_cached_json(clazz, id, object_reference, options)
        is_top_level_json = options[:is_top_level_json] || false
        object_reference = clazz.where(_id: id).first unless object_reference
        if !object_reference || (!is_top_level_json && options[:properties] != :all && clazz.hide_as_child_json_when.call(object_reference))
          nil
Severity: Minor
Found in lib/mongoid-cached-json/cached_json.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolve_json_reference has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def resolve_json_reference(options, object, _field, reference_def)
        keys = nil
        reference_json = nil
        if reference_def[:metadata]
          key = reference_def[:metadata].key.to_sym
Severity: Minor
Found in lib/mongoid-cached-json/cached_json.rb - About 1 hr to fix

    Method materialize_json has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def materialize_json(options, object_def)
        return nil if !object_def[:object] && !object_def[:id]
        is_top_level_json = options[:is_top_level_json] || false
        if object_def[:object]
          object_reference = object_def[:object]
    Severity: Minor
    Found in lib/mongoid-cached-json/cached_json.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def as_json_partial(options = {})
      json_keys = nil
      json = map do |i|
        if i.respond_to?(:as_json_partial)
          partial_json_keys, partial_json = i.as_json_partial(options)
      Severity: Minor
      Found in lib/mongoid-cached-json/mongoid_criteria.rb and 1 other location - About 40 mins to fix
      lib/mongoid-cached-json/array.rb on lines 2..13

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def as_json_partial(options = {})
    json_keys = nil
    json = map do |i|
      if i.respond_to?(:as_json_partial)
        partial_json_keys, json = i.as_json_partial(options)
      Severity: Minor
      Found in lib/mongoid-cached-json/array.rb and 1 other location - About 40 mins to fix
      lib/mongoid-cached-json/mongoid_criteria.rb on lines 3..14

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method as_json_partial has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def as_json_partial(options = {})
    json_keys = nil
    json = inject({}) do |h, (k, v)|
      if v.respond_to?(:as_json_partial)
        partial_json_keys, partial_json = v.as_json_partial(options)
      Severity: Minor
      Found in lib/mongoid-cached-json/hash.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method as_json_partial has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def as_json_partial(options = {})
      json_keys = nil
      json = map do |i|
        if i.respond_to?(:as_json_partial)
          partial_json_keys, partial_json = i.as_json_partial(options)
      Severity: Minor
      Found in lib/mongoid-cached-json/mongoid_criteria.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method as_json_partial has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def as_json_partial(options = {})
    json_keys = nil
    json = map do |i|
      if i.respond_to?(:as_json_partial)
        partial_json_keys, json = i.as_json_partial(options)
      Severity: Minor
      Found in lib/mongoid-cached-json/array.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language