morrisjdev/FileContextCore

View on GitHub

Showing 34 of 167 total issues

Method Initialize has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public void Initialize(IFileContextScopedOptions options, IEntityType entityType, object keyValueFactory)
        {
            _options = options;
            _entityType = entityType;
            _propertyKeys = entityType.GetProperties().Select(p => p.GetColumnName()).ToArray();
Severity: Major
Found in FileContextCore/StoreManager/EXCELStoreManager.cs - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
                Check.NotNull(optionsBuilder, nameof(optionsBuilder));
    
                var extension = optionsBuilder.Options.FindExtension<FileContextOptionsExtension>()
                                ?? new FileContextOptionsExtension();
    FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs on lines 179..200

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            {
                Check.NotNull(optionsBuilder, nameof(optionsBuilder));
    
                var extension = optionsBuilder.Options.FindExtension<FileContextOptionsExtension>()
                                ?? new FileContextOptionsExtension();
    FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs on lines 87..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method ExecuteTransaction has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public virtual int ExecuteTransaction(
                IList<IUpdateEntry> entries,
                IDiagnosticsLogger<DbLoggerCategory.Update> updateLogger)
            {
                var rowsAffected = 0;
    Severity: Minor
    Found in FileContextCore/Storage/Internal/FileContextStore.cs - About 1 hr to fix

      Method GetOrCreate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private ValueGenerator GetOrCreate(IProperty property)
              {
                  Check.NotNull(property, nameof(property));
      
                  var type = property.ClrType.UnwrapNullableType().UnwrapEnumType();

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                public void Initialize(IFileContextScopedOptions options, IEntityType entityType, object keyValueFactory)
                {
                    _entityType = entityType;
                    _keyValueFactory = keyValueFactory;
                    _propertyKeys = _entityType.GetProperties().Select(p => p.GetColumnName()).ToArray();
        Severity: Major
        Found in FileContextCore/Serializer/BSONSerializer.cs and 3 other locations - About 1 hr to fix
        FileContextCore/Serializer/CSVSerializer.cs on lines 21..27
        FileContextCore/Serializer/JSONSerializer.cs on lines 18..24
        FileContextCore/Serializer/XMLSerializer.cs on lines 25..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                public void Initialize(IFileContextScopedOptions options, IEntityType entityType, object keyValueFactory)
                {
                    _entityType = entityType;
                    _keyValueFactory = keyValueFactory;
                    _propertyKeys = _entityType.GetProperties().Select(p => p.GetColumnName()).ToArray();
        Severity: Major
        Found in FileContextCore/Serializer/XMLSerializer.cs and 3 other locations - About 1 hr to fix
        FileContextCore/Serializer/BSONSerializer.cs on lines 21..27
        FileContextCore/Serializer/CSVSerializer.cs on lines 21..27
        FileContextCore/Serializer/JSONSerializer.cs on lines 18..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                public void Initialize(IFileContextScopedOptions options, IEntityType entityType, object keyValueFactory)
                {
                    _keyValueFactory = keyValueFactory;
                    _entityType = entityType;
                    _propertyKeys = entityType.GetProperties().Select(p => p.GetColumnName()).ToArray();
        Severity: Major
        Found in FileContextCore/Serializer/CSVSerializer.cs and 3 other locations - About 1 hr to fix
        FileContextCore/Serializer/BSONSerializer.cs on lines 21..27
        FileContextCore/Serializer/JSONSerializer.cs on lines 18..24
        FileContextCore/Serializer/XMLSerializer.cs on lines 25..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                public void Initialize(IFileContextScopedOptions _, IEntityType entityType, object keyValueFactory)
                {
                    _keyValueFactory = keyValueFactory;
                    _entityType = entityType;
                    _propertyKeys = _entityType.GetProperties().Select(p => p.GetColumnName()).ToArray();
        Severity: Major
        Found in FileContextCore/Serializer/JSONSerializer.cs and 3 other locations - About 1 hr to fix
        FileContextCore/Serializer/BSONSerializer.cs on lines 21..27
        FileContextCore/Serializer/CSVSerializer.cs on lines 21..27
        FileContextCore/Serializer/XMLSerializer.cs on lines 25..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method Deserialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public static object Deserialize(this string input, Type type)
                {
                    if (string.IsNullOrEmpty(input))
                    {
                        return type.GetDefaultValue();
        Severity: Minor
        Found in FileContextCore/Serializer/SerializerHelper.cs - About 1 hr to fix

          Method AddEntityFrameworkFileContextDatabase has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public static IServiceCollection AddEntityFrameworkFileContextDatabase([NotNull] this IServiceCollection serviceCollection)
                  {
                      Check.NotNull(serviceCollection, nameof(serviceCollection));
          
                      var builder = new EntityFrameworkServicesBuilder(serviceCollection)

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    public string GetFileName()
                    {
                        string name = _type.GetTableName().GetValidFileName();
            
                        string path = string.IsNullOrEmpty(_location)
            Severity: Major
            Found in FileContextCore/FileManager/PrivateFileManager.cs and 1 other location - About 1 hr to fix
            FileContextCore/FileManager/DefaultFileManager.cs on lines 28..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    public string GetFileName()
                    {
                        string name = _type.GetTableName().GetValidFileName();
            
                        string path = string.IsNullOrEmpty(_location)
            Severity: Major
            Found in FileContextCore/FileManager/DefaultFileManager.cs and 1 other location - About 1 hr to fix
            FileContextCore/FileManager/PrivateFileManager.cs on lines 26..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method VisitBinary has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        protected override Expression VisitBinary(BinaryExpression binaryExpression)
                        {
                            if (binaryExpression.NodeType == ExpressionType.Assign
                                && binaryExpression.Left is ParameterExpression parameterExpression
                                && parameterExpression.Type == typeof(MaterializationContext))

              Method UseFileContextDatabase has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                          [NotNull] this DbContextOptionsBuilder optionsBuilder,
                          string databaseName = "",
                          string location = null,
                          string password = null,
                          [CanBeNull] FileContextDatabaseRoot databaseRoot = null,
              Severity: Minor
              Found in FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs - About 45 mins to fix

                Method WithCustomOptions has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        public virtual FileContextOptionsExtension WithCustomOptions(string databaseName, string location, string password, Type storeManagerType, Type serializerType, Type fileManagerType)
                Severity: Minor
                Found in FileContextCore/Infrastructure/Internal/FileContextOptionsExtension.cs - About 45 mins to fix

                  Method UseFileContextDatabase has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                              [NotNull] this DbContextOptionsBuilder optionsBuilder,
                              string databaseName = "",
                              string location = null,
                              string password = null,
                              [CanBeNull] FileContextDatabaseRoot databaseRoot = null,
                  Severity: Minor
                  Found in FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs - About 45 mins to fix

                    Method UseFileContextDatabase has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                                [NotNull] this DbContextOptionsBuilder<TContext> optionsBuilder,
                                string databaseName = "",
                                string location = null,
                                string password = null,
                                [CanBeNull] FileContextDatabaseRoot databaseRoot = null,
                    Severity: Minor
                    Found in FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs - About 45 mins to fix

                      Method UseFileContextDatabase has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                                  [NotNull] this DbContextOptionsBuilder optionsBuilder,
                                  string databaseName = "",
                                  string location = null,
                                  string password = null,
                                  [CanBeNull] FileContextDatabaseRoot databaseRoot = null,
                      Severity: Minor
                      Found in FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs - About 45 mins to fix

                        Method UseFileContextDatabase has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                    [NotNull] this DbContextOptionsBuilder<TContext> optionsBuilder,
                                    string databaseName = "",
                                    string location = null,
                                    string password = null,
                                    [CanBeNull] FileContextDatabaseRoot databaseRoot = null,
                        Severity: Minor
                        Found in FileContextCore/Extensions/FileContextDbContextOptionsExtensions.cs - About 45 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language