motom001/DoorPi

View on GitHub
doorpi/sipphone/from_linphone.py

Summary

Maintainability
D
1 day
Test Coverage

Function start has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def start(self):
        DoorPi().event_handler('OnSipPhoneCreate', __name__)
        self.core.max_calls = conf.get_int(SIPPHONE_SECTION, 'ua.max_calls', 2)
        self.core.echo_cancellation_enabled = conf.get_bool(SIPPHONE_SECTION, 'echo_cancellation_enabled', False)
        
Severity: Minor
Found in doorpi/sipphone/from_linphone.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File from_linphone.py has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
# -*- coding: utf-8 -*-

import logging
logger = logging.getLogger(__name__)
Severity: Minor
Found in doorpi/sipphone/from_linphone.py - About 2 hrs to fix

    LinPhone has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LinPhone(SipphoneAbstractBaseClass):
    
        @property
        def name(self): return 'linphone wrapper'
    
    
    Severity: Minor
    Found in doorpi/sipphone/from_linphone.py - About 2 hrs to fix

      Function call has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def call(self, number):
              DoorPi().event_handler('BeforeSipPhoneMakeCall', __name__, {'number':number})
              logger.debug("call (%s)",str(number))
              if not self.current_call:
                  logger.debug('no current call -> start new call')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function self_check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self_check(self, *args, **kwargs):
              if not self.core: return
      
              self.core.iterate()
      
      
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Refactor this function to reduce its Cognitive Complexity from 34 to the 15 allowed.
      Open

          def start(self):
      Severity: Critical
      Found in doorpi/sipphone/from_linphone.py by sonar-python

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Either merge this branch with the identical one on line "184" or change one of the implementations.
      Open

              else: self.core.firewall_policy = lin.FirewallPolicy.PolicyNoFirewall

      Having two branches in the same if structure with the same implementation is at best duplicate code, and at worst a coding error. If the same logic is truly needed for both instances, then they should be combined.

      Noncompliant Code Example

      if 0 <= a < 10:
          do_the_thing()
      elif 10 <= a < 20:
          do_the_other_thing()
      elif 20 <= a < 50:
          do_the_thing()  # Noncompliant; duplicates first condition
      else:
          do_the_rest()
      
      b = 4 if a > 12 else 4
      

      Compliant Solution

      if (0 <= a < 10) or (20 <= a < 50):
          do_the_thing()
      elif 10 <= a < 20:
          do_the_other_thing()
      else:
          do_the_rest()
      
      b = 4
      

      or

      if 0 <= a < 10:
          do_the_thing()
      elif 10 <= a < 20:
          do_the_other_thing()
      elif 20 <= a < 50:
          do_the_third_thing()
      else:
          do_the_rest()
      
      b = 8 if a > 12 else 4
      

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if int(self.current_call_duration) > self.core.in_call_timeout - 0.5:
                      logger.info("max call time reached - hangup current call after %s seconds (max. %s)", self.current_call_duration, self.core.in_call_timeout)
                      self.core.terminate_all_calls()
                      DoorPi().event_handler('OnSipPhoneCallTimeoutMaxCalltime', __name__)
      Severity: Major
      Found in doorpi/sipphone/from_linphone.py and 1 other location - About 1 hr to fix
      doorpi/sipphone/from_linphone.py on lines 305..308

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if self.current_call_duration > self.core.inc_timeout - 0.5:
                      logger.info("call timeout - hangup current call after %s seconds (max. %s)", self.current_call_duration, self.core.inc_timeout)
                      self.core.terminate_all_calls()
                      DoorPi().event_handler('OnSipPhoneCallTimeoutNoResponse', __name__)
      Severity: Major
      Found in doorpi/sipphone/from_linphone.py and 1 other location - About 1 hr to fix
      doorpi/sipphone/from_linphone.py on lines 310..313

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Unexpected spaces around keyword / parameter equals
      Open

          def __init__(self, whitelist = list(), *args, **kwargs):
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Don't use spaces around the '=' sign in function arguments.

      Don't use spaces around the '=' sign when used to indicate a
      keyword argument or a default parameter value, except when
      using a type annotation.
      
      Okay: def complex(real, imag=0.0):
      Okay: return magic(r=real, i=imag)
      Okay: boolean(a == b)
      Okay: boolean(a != b)
      Okay: boolean(a <= b)
      Okay: boolean(a >= b)
      Okay: def foo(arg: int = 42):
      Okay: async def foo(arg: int = 42):
      
      E251: def complex(real, imag = 0.0):
      E251: return magic(r = real, i = imag)
      E252: def complex(real, image: float=0.0):

      Line too long (164 > 79 characters)
      Open

              self.core.sip_transports = lin.SipTransports(conf.get_int(SIPPHONE_SECTION, 'local_port', 5060), conf.get_int(SIPPHONE_SECTION, 'local_port', 5060), -1, -1)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

              elif firewall_policy == "PolicyUseStun": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseStun
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Line too long (107 > 79 characters)
      Open

              elif firewall_policy == "PolicyUseIce": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseIce
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (98 > 79 characters)
      Open

              #If an incoming call isn’t answered for this timeout period, it is automatically declined.
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (109 > 79 characters)
      Open

                  self.core.capture_device = conf.get(SIPPHONE_SECTION, 'capture_device', self.core.capture_device)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (83 > 79 characters)
      Open

                      DoorPi().event_handler('OnSipPhoneCallTimeoutNoResponse', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (98 > 79 characters)
      Open

                      logger.debug("same call %s again while call is running since %s seconds? -> skip",
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (109 > 79 characters)
      Open

                      logger.debug("press twice with call duration > 1 second? Want to hangup current call? OK...")
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

          if "pylinphone_Core_instance_method_iterate" in msg: return
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Multiple statements on one line (colon)
      Open

          if ": keep alive sent to [" in msg: return
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Expected 2 blank lines, found 0
      Open

      class LinPhone(SipphoneAbstractBaseClass):
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
      line.
      
      Extra blank lines may be used (sparingly) to separate groups of
      related functions.  Blank lines may be omitted between a bunch of
      related one-liners (e.g. a set of dummy implementations).
      
      Use blank lines in functions, sparingly, to indicate logical
      sections.
      
      Okay: def a():\n    pass\n\n\ndef b():\n    pass
      Okay: def a():\n    pass\n\n\nasync def b():\n    pass
      Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
      Okay: default = 1\nfoo = 1
      Okay: classify = 1\nfoo = 1
      
      E301: class Foo:\n    b = 0\n    def bar():\n        pass
      E302: def a():\n    pass\n\ndef b(n):\n    pass
      E302: def a():\n    pass\n\nasync def b(n):\n    pass
      E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
      E303: def a():\n\n\n\n    pass
      E304: @decorator\n\ndef a():\n    pass
      E305: def a():\n    pass\na()
      E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Blank line contains whitespace
      Open

              
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Trailing whitespace is superfluous.

      The warning returned varies on whether the line itself is blank,
      for easier filtering for those who want to indent their blank lines.
      
      Okay: spam(1)\n#
      W291: spam(1) \n#
      W293: class Foo(object):\n    \n    bang = 12

      Line too long (84 > 79 characters)
      Open

                      DoorPi().event_handler('OnSipPhoneCallTimeoutMaxCalltime', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Module level import not at top of file
      Open

      import linphone as lin
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Module level import not at top of file
      Open

      from doorpi import DoorPi
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Line too long (92 > 79 characters)
      Open

              diff_start_and_now = datetime.datetime.utcnow() - self.__current_call_start_datetime
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (93 > 79 characters)
      Open

                      'direction':        'incoming' if self.current_call.dir == 0 else 'outgoing',
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Block comment should start with '# '
      Open

              #http://pythonhosted.org/linphone/api_reference.html#linphone.Core.inc_timeout
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Line too long (85 > 79 characters)
      Open

                          'X' if self.core.sound_device_can_capture(sound_device) else 'O',
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (86 > 79 characters)
      Open

                          'X' if self.core.sound_device_can_playback(sound_device) else 'O',
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Continuation line under-indented for visual indent
      Open

                          'X' if self.core.sound_device_can_playback(sound_device) else 'O',
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      Line too long (100 > 79 characters)
      Open

                  self.core.preferred_video_size_by_name = conf.get(SIPPHONE_SECTION, 'video_size', 'vga')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

          if "pylinphone_Call_from_native_ptr" in msg: return
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Missing whitespace around modulo operator
      Open

              self.core.primary_contact = '%s <sip:doorpi@127.0.0.1>'%conf.get(SIPPHONE_SECTION, "identity", 'DoorPi')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Blank line contains whitespace
      Open

              
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Trailing whitespace is superfluous.

      The warning returned varies on whether the line itself is blank,
      for easier filtering for those who want to indent their blank lines.
      
      Okay: spam(1)\n#
      W291: spam(1) \n#
      W293: class Foo(object):\n    \n    bang = 12

      Line too long (121 > 79 characters)
      Open

              elif firewall_policy == "PolicyUseNatAddress": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseNatAddress
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

              elif firewall_policy == "PolicyUseUpnp": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseUpnp
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Multiple statements on one line (colon)
      Open

              if not self.core: return
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Multiple statements on one line (colon)
      Open

              if not self.current_call: return
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Line too long (85 > 79 characters)
      Open

              DoorPi().event_handler('BeforeSipPhoneMakeCall', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Module level import not at top of file
      Open

      from doorpi.sipphone.linphone_lib.CallBacks import LinphoneCallbacks
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Expected 2 blank lines after class or function definition, found 1
      Open

      if logger.getEffectiveLevel() <= 5: lin.set_log_handler(log_handler)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
      line.
      
      Extra blank lines may be used (sparingly) to separate groups of
      related functions.  Blank lines may be omitted between a bunch of
      related one-liners (e.g. a set of dummy implementations).
      
      Use blank lines in functions, sparingly, to indicate logical
      sections.
      
      Okay: def a():\n    pass\n\n\ndef b():\n    pass
      Okay: def a():\n    pass\n\n\nasync def b():\n    pass
      Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
      Okay: default = 1\nfoo = 1
      Okay: classify = 1\nfoo = 1
      
      E301: class Foo:\n    b = 0\n    def bar():\n        pass
      E302: def a():\n    pass\n\ndef b(n):\n    pass
      E302: def a():\n    pass\n\nasync def b(n):\n    pass
      E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
      E303: def a():\n\n\n\n    pass
      E304: @decorator\n\ndef a():\n    pass
      E305: def a():\n    pass\na()
      E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Line too long (111 > 79 characters)
      Open

          #TODO: Datetime from linphone CallLog.start_date is more then 30 sec different to python datetime.utcnow()?
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (80 > 79 characters)
      Open

              DoorPi().event_handler.register_event('AfterSipPhoneMakeCall', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (113 > 79 characters)
      Open

              if firewall_policy == "PolicyNoFirewall": self.core.firewall_policy = lin.FirewallPolicy.PolicyNoFirewall
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (81 > 79 characters)
      Open

              DoorPi().event_handler.fire_event_synchron('OnSipPhoneDestroy', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (156 > 79 characters)
      Open

                      logger.info("max call time reached - hangup current call after %s seconds (max. %s)", self.current_call_duration, self.core.in_call_timeout)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Missing whitespace after ':'
      Open

                          DoorPi().event_handler('OnSipPhoneMakeCallFailed', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Module level import not at top of file
      Open

      from doorpi.sipphone.linphone_lib.Recorder import LinphoneRecorder
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Expected 2 blank lines, found 1
      Open

      def get(*args, **kwargs): return LinPhone(*args, **kwargs)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
      line.
      
      Extra blank lines may be used (sparingly) to separate groups of
      related functions.  Blank lines may be omitted between a bunch of
      related one-liners (e.g. a set of dummy implementations).
      
      Use blank lines in functions, sparingly, to indicate logical
      sections.
      
      Okay: def a():\n    pass\n\n\ndef b():\n    pass
      Okay: def a():\n    pass\n\n\nasync def b():\n    pass
      Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
      Okay: default = 1\nfoo = 1
      Okay: classify = 1\nfoo = 1
      
      E301: class Foo:\n    b = 0\n    def bar():\n        pass
      E302: def a():\n    pass\n\ndef b(n):\n    pass
      E302: def a():\n    pass\n\nasync def b(n):\n    pass
      E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
      E303: def a():\n\n\n\n    pass
      E304: @decorator\n\ndef a():\n    pass
      E305: def a():\n    pass\na()
      E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Multiple statements on one line (colon)
      Open

              elif firewall_policy == "PolicyUseIce": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseIce
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Line too long (105 > 79 characters)
      Open

                      logger.debug('switching to first possible video device "%s"', self.core.video_devices[0])
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Missing whitespace after ','
      Open

                  logger.debug('%s',self.core.proxy_config_list)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Line too long (113 > 79 characters)
      Open

              self.core.echo_cancellation_enabled = conf.get_bool(SIPPHONE_SECTION, 'echo_cancellation_enabled', False)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (90 > 79 characters)
      Open

              firewall_policy = conf.get(SIPPHONE_SECTION, 'FirewallPolicy', 'PolicyNoFirewall')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Missing whitespace around modulo operator
      Open

                  proxy_cfg.server_addr = "sip:%s"%server
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Surround operators with a single space on either side.

      - Always surround these binary operators with a single space on
        either side: assignment (=), augmented assignment (+=, -= etc.),
        comparisons (==, <, >, !=, <=, >=, in, not in, is, is not),
        Booleans (and, or, not).
      
      - If operators with different priorities are used, consider adding
        whitespace around the operators with the lowest priorities.
      
      Okay: i = i + 1
      Okay: submitted += 1
      Okay: x = x * 2 - 1
      Okay: hypot2 = x * x + y * y
      Okay: c = (a + b) * (a - b)
      Okay: foo(bar, key='word', *args, **kwargs)
      Okay: alpha[:-i]
      
      E225: i=i+1
      E225: submitted +=1
      E225: x = x /2 - 1
      E225: z = x **y
      E225: z = 1and 1
      E226: c = (a+b) * (a-b)
      E226: hypot2 = x*x + y*y
      E227: c = a|b
      E228: msg = fmt%(errno, errmsg)

      Blank line at end of file
      Open

      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Trailing blank lines are superfluous.

      Okay: spam(1)
      W391: spam(1)\n
      
      However the last line should end with a new line (warning W292).

      Multiple statements on one line (colon)
      Open

          if "pylinphone_Core_get_current_call" in msg: return
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Line too long (99 > 79 characters)
      Open

              logger.debug('reset current call start datetime to %s', self.__current_call_start_datetime)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (83 > 79 characters)
      Open

              DoorPi().event_handler.register_event('OnSipPhoneRecorderCreate', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (81 > 79 characters)
      Open

              DoorPi().event_handler.register_event('BeforeSipPhoneMakeCall', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

              if firewall_policy == "PolicyNoFirewall": self.core.firewall_policy = lin.FirewallPolicy.PolicyNoFirewall
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Block comment should start with '# '
      Open

              #http://pythonhosted.org/linphone/api_reference.html#linphone.Core.in_call_timeout
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Closing bracket does not match visual indentation
      Open

                      )
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      Missing whitespace after ':'
      Open

              DoorPi().event_handler('BeforeSipPhoneMakeCall', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Line too long (99 > 79 characters)
      Open

                          DoorPi().event_handler('OnSipPhoneMakeCallFailed', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Module level import not at top of file
      Open

      from doorpi.sipphone.linphone_lib.Player import LinphonePlayer
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Line too long (83 > 79 characters)
      Open

              DoorPi().event_handler.register_event('OnSipPhoneMakeCallFailed', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (90 > 79 characters)
      Open

              DoorPi().event_handler.register_event('OnSipPhoneCallTimeoutNoResponse', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (91 > 79 characters)
      Open

              DoorPi().event_handler.register_event('OnSipPhoneCallTimeoutMaxCalltime', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Continuation line under-indented for visual indent
      Open

                          sound_device
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      Line too long (114 > 79 characters)
      Open

                      logger.warning('camera "%s" from config does not exist in possible video devices.', config_camera)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (87 > 79 characters)
      Open

                          conf.get(SIPPHONE_SECTION, "identity", 'DoorPi'), username, server)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (95 > 79 characters)
      Open

                  auth_info = self.core.create_auth_info(username, None, password, None, None, realm)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Expected 2 blank lines, found 1
      Open

      def log_handler(level, msg):
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
      line.
      
      Extra blank lines may be used (sparingly) to separate groups of
      related functions.  Blank lines may be omitted between a bunch of
      related one-liners (e.g. a set of dummy implementations).
      
      Use blank lines in functions, sparingly, to indicate logical
      sections.
      
      Okay: def a():\n    pass\n\n\ndef b():\n    pass
      Okay: def a():\n    pass\n\n\nasync def b():\n    pass
      Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
      Okay: default = 1\nfoo = 1
      Okay: classify = 1\nfoo = 1
      
      E301: class Foo:\n    b = 0\n    def bar():\n        pass
      E302: def a():\n    pass\n\ndef b(n):\n    pass
      E302: def a():\n    pass\n\nasync def b(n):\n    pass
      E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
      E303: def a():\n\n\n\n    pass
      E304: @decorator\n\ndef a():\n    pass
      E305: def a():\n    pass\na()
      E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Line too long (81 > 79 characters)
      Open

                        'capture':    self.core.sound_device_can_capture(sound_device),
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Module level import not at top of file
      Open

      import datetime
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Multiple statements on one line (colon)
      Open

              if not self.current_call: return 0
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Continuation line under-indented for visual indent
      Open

                          'X' if self.core.sound_device_can_capture(sound_device) else 'O',
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      Unexpected spaces around keyword / parameter equals
      Open

          def __init__(self, whitelist = list(), *args, **kwargs):
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Don't use spaces around the '=' sign in function arguments.

      Don't use spaces around the '=' sign when used to indicate a
      keyword argument or a default parameter value, except when
      using a type annotation.
      
      Okay: def complex(real, imag=0.0):
      Okay: return magic(r=real, i=imag)
      Okay: boolean(a == b)
      Okay: boolean(a != b)
      Okay: boolean(a <= b)
      Okay: boolean(a >= b)
      Okay: def foo(arg: int = 42):
      Okay: async def foo(arg: int = 42):
      
      E251: def complex(real, imag = 0.0):
      E251: return magic(r = real, i = imag)
      E252: def complex(real, image: float=0.0):

      Too many blank lines (2)
      Open

              if len(self.core.video_devices) == 0:
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
      line.
      
      Extra blank lines may be used (sparingly) to separate groups of
      related functions.  Blank lines may be omitted between a bunch of
      related one-liners (e.g. a set of dummy implementations).
      
      Use blank lines in functions, sparingly, to indicate logical
      sections.
      
      Okay: def a():\n    pass\n\n\ndef b():\n    pass
      Okay: def a():\n    pass\n\n\nasync def b():\n    pass
      Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
      Okay: default = 1\nfoo = 1
      Okay: classify = 1\nfoo = 1
      
      E301: class Foo:\n    b = 0\n    def bar():\n        pass
      E302: def a():\n    pass\n\ndef b(n):\n    pass
      E302: def a():\n    pass\n\nasync def b(n):\n    pass
      E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
      E303: def a():\n\n\n\n    pass
      E304: @decorator\n\ndef a():\n    pass
      E305: def a():\n    pass\na()
      E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Line too long (86 > 79 characters)
      Open

              #http://pythonhosted.org/linphone/api_reference.html#linphone.Core.inc_timeout
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (105 > 79 characters)
      Open

                      if DoorPi().event_handler.db.get_event_log_entries_count('OnSipPhoneMakeCallFailed') > 5:
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (105 > 79 characters)
      Open

              self.core.video_display_enabled = conf.get_bool(SIPPHONE_SECTION, 'video_display_enabled', False)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

              elif firewall_policy == "PolicyUseNatAddress": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseNatAddress
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Block comment should start with '# '
      Open

              #After this timeout period, the call is automatically hangup.
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Block comment should start with '# '
      Open

              #If an incoming call isn’t answered for this timeout period, it is automatically declined.
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Line too long (82 > 79 characters)
      Open

              self.core.inc_timeout = conf.get_int(SIPPHONE_SECTION, 'call_timeout', 15)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (80 > 79 characters)
      Open

                  logger.debug("using playback_device: %s", self.core.playback_device)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (98 > 79 characters)
      Open

                  config_camera = conf.get(SIPPHONE_SECTION, 'video_device', self.core.video_devices[0])
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (90 > 79 characters)
      Open

                  if codec.mime_type in config_video_codecs and self.core.video_capture_enabled:
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Missing whitespace after ','
      Open

              logger.debug("call (%s)",str(number))
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Line too long (88 > 79 characters)
      Open

                                   self.core.current_call.remote_address.as_string_uri_only(),
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Module level import not at top of file
      Open

      from AbstractBaseClass import SipphoneAbstractBaseClass, SIPPHONE_SECTION
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Block comment should start with '# '
      Open

          #TODO: Datetime from linphone CallLog.start_date is more then 30 sec different to python datetime.utcnow()?
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Line too long (109 > 79 characters)
      Open

              elif firewall_policy == "PolicyUseStun": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseStun
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (109 > 79 characters)
      Open

              elif firewall_policy == "PolicyUseUpnp": self.core.firewall_policy = lin.FirewallPolicy.PolicyUseUpnp
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (90 > 79 characters)
      Open

              #http://pythonhosted.org/linphone/api_reference.html#linphone.Core.in_call_timeout
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (90 > 79 characters)
      Open

              config_audio_codecs = conf.get_list(SIPPHONE_SECTION, 'audio_codecs', 'PCMA,PCMU')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (84 > 79 characters)
      Open

              config_video_codecs = conf.get_list(SIPPHONE_SECTION, 'video_codecs', 'VP8')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (143 > 79 characters)
      Open

                      logger.info("call timeout - hangup current call after %s seconds (max. %s)", self.current_call_duration, self.core.inc_timeout)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (81 > 79 characters)
      Open

                  if int(self.current_call_duration) > self.core.in_call_timeout - 0.5:
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (85 > 79 characters)
      Open

                  DoorPi().event_handler('OnSipPhoneMakeCall', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (84 > 79 characters)
      Open

              DoorPi().event_handler('AfterSipPhoneMakeCall', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

      if logger.getEffectiveLevel() <= 5: lin.set_log_handler(log_handler)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Line too long (88 > 79 characters)
      Open

                  logger.info("found %s possible sounddevices:", len(self.core.sound_devices))
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (88 > 79 characters)
      Open

                  logger.info("found %s possible videodevices:", len(self.core.video_devices))
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (81 > 79 characters)
      Open

                        'record':     self.core.sound_device_can_playback(sound_device)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (112 > 79 characters)
      Open

              self.core.primary_contact = '%s <sip:doorpi@127.0.0.1>'%conf.get(SIPPHONE_SECTION, "identity", 'DoorPi')
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Multiple statements on one line (colon)
      Open

              else: self.core.firewall_policy = lin.FirewallPolicy.PolicyNoFirewall
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Compound statements (on the same line) are generally discouraged.

      While sometimes it's okay to put an if/for/while with a small body
      on the same line, never do this for multi-clause statements.
      Also avoid folding such long lines!
      
      Always use a def statement instead of an assignment statement that
      binds a lambda expression directly to a name.
      
      Okay: if foo == 'blah':\n    do_blah_thing()
      Okay: do_one()
      Okay: do_two()
      Okay: do_three()
      
      E701: if foo == 'blah': do_blah_thing()
      E701: for x in lst: total += x
      E701: while t < 10: t = delay()
      E701: if foo == 'blah': do_blah_thing()
      E701: else: do_non_blah_thing()
      E701: try: something()
      E701: finally: cleanup()
      E701: if foo == 'blah': one(); two(); three()
      E702: do_one(); do_two(); do_three()
      E703: do_four();  # useless semicolon
      E704: def f(x): return 2*x
      E731: f = lambda x: 2*x

      Line too long (88 > 79 characters)
      Open

              self.core.in_call_timeout = conf.get_int(SIPPHONE_SECTION, 'max_call_time', 120)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (112 > 79 characters)
      Open

                  self.core.playback_device = conf.get(SIPPHONE_SECTION, 'playback_device', self.core.playback_device)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (86 > 79 characters)
      Open

                  self.core.mic_gain_db = conf.get_float(SIPPHONE_SECTION, 'mic_gain_db', 0)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Closing bracket does not match visual indentation
      Open

                      )
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      Module level import not at top of file
      Open

      from doorpi.media.CreateDialTone import generate_dial_tone
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Place imports at the top of the file.

      Always put imports at the top of the file, just after any module
      comments and docstrings, and before module globals and constants.
      
      Okay: import os
      Okay: # this is a comment\nimport os
      Okay: '''this is a module docstring'''\nimport os
      Okay: r'''this is a module docstring'''\nimport os
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nelse:\n\tpass\nimport y
      Okay:
      try:\n\timport x\nexcept ImportError:\n\tpass\nfinally:\n\tpass\nimport y
      E402: a=1\nimport os
      E402: 'One string'\n"Two string"\nimport os
      E402: a=1\nfrom sys import x
      
      Okay: if x:\n    import os

      Line too long (84 > 79 characters)
      Open

              DoorPi().event_handler.register_event('OnSipPhoneRecorderDestroy', __name__)
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Block comment should start with '# '
      Open

              #http://pythonhosted.org/linphone/api_reference.html#linphone.Core.new
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
      Inline comments should be separated by at least two spaces from the
      statement. They should start with a # and a single space.
      
      Each line of a block comment starts with a # and a single space
      (unless it is indented text inside the comment).
      
      Okay: x = x + 1  # Increment x
      Okay: x = x + 1    # Increment x
      Okay: # Block comment
      E261: x = x + 1 # Increment x
      E262: x = x + 1  #Increment x
      E262: x = x + 1  #  Increment x
      E265: #Block comment
      E266: ### Block comment

      Missing whitespace after ':'
      Open

                  DoorPi().event_handler('OnSipPhoneMakeCall', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      Missing whitespace after ':'
      Open

              DoorPi().event_handler('AfterSipPhoneMakeCall', __name__, {'number':number})
      Severity: Minor
      Found in doorpi/sipphone/from_linphone.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
      Okay: (3,)
      Okay: a[1:4]
      Okay: a[:4]
      Okay: a[1:]
      Okay: a[1:4:2]
      E231: ['a','b']
      E231: foo(bar,baz)
      E231: [{'a':'b'}]

      There are no issues that match your filters.

      Category
      Status