motom001/DoorPi

View on GitHub
doorpi/status/requirements_lib/req_system.py

Summary

Maintainability
A
40 mins
Test Coverage

Similar blocks of code found in 23 locations. Consider refactoring.
Open

    libraries = dict(
        importlib = dict(
            text_warning =          '',
            text_description =      'Das Python-Modul importlib wird zum dynamischen Laden von Dateien genutzt. So sind z.B. alle Actions jeweils als eigene Datei abgelegt die anhand des Dateinamens (= Name der Action) geladen werden, wenn diese auch wirklich benötigt werden. So muss am restlichen Quellcode keine Anpassung gemacht werden und es reicht eine neue Aktion bereit zu stellen.',
            text_installation =     'Eine Installation ist nicht nötig, da es sich hierbei um eine Python-Standard-Modul handelt.',
Severity: Major
Found in doorpi/status/requirements_lib/req_system.py and 22 other locations - About 40 mins to fix
doorpi/status/requirements_lib/req_config.py on lines 19..43
doorpi/status/requirements_lib/req_event_handler.py on lines 24..33
doorpi/status/requirements_lib/req_event_handler.py on lines 24..45
doorpi/status/requirements_lib/req_system.py on lines 16..41
doorpi/status/requirements_lib/req_system.py on lines 16..61
doorpi/status/requirements_lib/req_system.py on lines 16..75
doorpi/status/requirements_lib/req_system.py on lines 16..89
doorpi/status/requirements_lib/req_system.py on lines 16..103
doorpi/status/requirements_lib/req_system.py on lines 16..117
doorpi/status/requirements_lib/req_system.py on lines 16..131
doorpi/status/requirements_lib/req_system.py on lines 16..145
doorpi/status/requirements_lib/req_system.py on lines 16..159
doorpi/status/requirements_lib/req_system.py on lines 16..173
doorpi/status/requirements_lib/req_system.py on lines 16..187
doorpi/status/requirements_lib/req_system.py on lines 16..201
doorpi/status/requirements_lib/req_system.py on lines 16..215
doorpi/status/requirements_lib/req_system.py on lines 16..229
doorpi/status/requirements_lib/req_system.py on lines 16..243
doorpi/status/requirements_lib/req_webserver.py on lines 99..110
doorpi/status/requirements_lib/req_webserver.py on lines 99..124
doorpi/status/requirements_lib/req_webserver.py on lines 99..138
doorpi/status/requirements_lib/req_webserver.py on lines 99..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status