Sign upLogin

movemeet/movemeet

View on GitHub
Star
app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java

Summary

Maintainability
D
2 days
Test Coverage
C
71%

File ActivityDescriptionActivity.java has 385 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.sdp.movemeet.view.activity;

import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
Severity: Minor
Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 5 hrs to fix

    ActivityDescriptionActivity has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
public class ActivityDescriptionActivity extends AppCompatActivity {

    private static final String TAG = "ActDescActivity";
    public static final String PARTICIPANT_ID_FIELD = "participantId";
    Severity: Minor
    Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 3 hrs to fix

      Method setButton has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private void setButton(Activity activity) {
        View recButton = findViewById(R.id.activityGPSRecDescription);
        if (activity.getParticipantId().contains(userId)) {
            findViewById(R.id.activityRegisterDescription).setVisibility(View.GONE);
            findViewById(R.id.activityChatDescription).setVisibility(View.VISIBLE);
      Severity: Minor
      Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setButton has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void setButton(Activity activity) {
        View recButton = findViewById(R.id.activityGPSRecDescription);
        if (activity.getParticipantId().contains(userId)) {
            findViewById(R.id.activityRegisterDescription).setVisibility(View.GONE);
            findViewById(R.id.activityChatDescription).setVisibility(View.VISIBLE);
      Severity: Minor
      Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 1 hr to fix

        Method unregisterFromActivityImplementation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
    public void unregisterFromActivityImplementation(Activity activity, String userId, String organizerId) {
        if (activity.getParticipantId().contains(userId)) {
            if (!userId.equals(organizerId)) {
                try {
        Severity: Minor
        Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 1 hr to fix

          Method unregisterFromActivityImplementation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
    public void unregisterFromActivityImplementation(Activity activity, String userId, String organizerId) {
        if (activity.getParticipantId().contains(userId)) {
            if (!userId.equals(organizerId)) {
                try {
          Severity: Minor
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onCreate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_description);
          Severity: Minor
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getParticipantNames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private void getParticipantNames(Activity activity) {
        ArrayList<String> participantIds = activity.getParticipantId();
        additionalParticipantsView.setVisibility(View.GONE);
        participantNamesString = new StringBuilder();
        Boolean finishList = false;
          Severity: Minor
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (!userId.equals(organizerId)) {
                try {
                    activity.removeParticipantId(userId);
                    createParticipantNumberView(activity);
                    // Removing the activity path from the array field "registeredActivity" of the
          Severity: Major
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java and 1 other location - About 2 hrs to fix
          app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java on lines 282..308

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (!activity.getParticipantId().contains(userId)) {
            try {
                activity.addParticipantId(userId);
                createParticipantNumberView(activity);
                // Adding the activity path to the array field "registeredActivity" of the Firebase
          Severity: Major
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java and 1 other location - About 2 hrs to fix
          app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java on lines 323..349

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    protected void onActivityResult(int requestCode, int resultCode, @androidx.annotation.Nullable Intent data) {
        super.onActivityResult(requestCode, resultCode, data);
        if (requestCode == REQUEST_IMAGE) {
            if (resultCode == android.app.Activity.RESULT_OK) {
          Severity: Major
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java and 1 other location - About 1 hr to fix
          app/src/main/java/com/sdp/movemeet/view/profile/EditProfileActivity.java on lines 140..151

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private void loadActivityHeaderPicture() {
        activityImage = findViewById(R.id.activity_image_description);
        progressBar = findViewById(R.id.progress_bar_activity_description);
        imagePath = activity.getDocumentPath() + ImageHandler.PATH_SEPARATOR + ImageHandler.ACTIVITY_IMAGE_NAME;
        Image image = new Image(null, activityImage);
          Severity: Major
          Found in app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivity.java and 1 other location - About 1 hr to fix
          app/src/main/java/com/sdp/movemeet/view/activity/ActivityDescriptionActivityUnregister.java on lines 127..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status