app/src/main/java/com/sdp/movemeet/view/activity/UploadActivityActivity.java
File UploadActivityActivity.java
has 268 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
package com.sdp.movemeet.view.activity;
import android.app.DatePickerDialog;
import android.app.Dialog;
import android.app.TimePickerDialog;
Method validateActivity
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
public Activity validateActivity() {
String organizerId = fAuth.getCurrentUser().getUid();
Sport sport = Sport.valueOf(spinner.getSelectedItem().toString());
Method onCreate
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_upload_activity);
Method validateActivity
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
public Activity validateActivity() {
String organizerId = fAuth.getCurrentUser().getUid();
Sport sport = Sport.valueOf(spinner.getSelectedItem().toString());
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return activity;
Method onCreate
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_upload_activity);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"