Showing 24 of 24 total issues
Identical blocks of code found in 2 locations. Consider refactoring. Open
def status
text = "#{BLUE}##### Processed commands #{@counts[:commands_finished]} of #{@counts[:commands]}"
if @counts[:tests_success] > 0
text += ", #{GREEN}success tests #{@counts[:tests_success]} of #{@counts[:tests]}"
end
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 97.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
def status
text = "#{BLUE}##### Processed commands #{@counts[:commands_finished]} of #{@counts[:commands]}"
if @counts[:tests_success] > 0
text += ", #{GREEN}success tests #{@counts[:tests_success]} of #{@counts[:tests]}"
end
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 97.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method parse_env
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def parse_env output
env = []
holder=nil
terminator=nil
output.each do |line|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method load
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def load file_name
lines = []
file_lines = File.readlines(file_name)
shell = "bash"
shell = file_lines.shift.sub(/^#!/,'') if file_lines[0] =~ /^#!/
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_test
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def process_test test
name, commands, execution_shell = test[:name], test[:commands], test[:shell]
shell = Session::Sh.new(:prog => execution_shell)
_env = env(shell)
@plugins.output_plugins(:start_test, test, _env)
Method parse_env
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse_env output
env = []
holder=nil
terminator=nil
output.each do |line|
Method match_arg_klass
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def match_arg_klass arg, klass, type
klass = TF.const_get(klass)
return nil unless klass.respond_to? :argument_matches?
matches = klass.argument_matches? arg
return nil if matches.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_test
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def process_test test
name, commands, execution_shell = test[:name], test[:commands], test[:shell]
shell = Session::Sh.new(:prog => execution_shell)
_env = env(shell)
@plugins.output_plugins(:start_test, test, _env)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method execute_one
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute_one test, matcher, _stdout, _stderr, _stdboth, _status, env
Method execute_all
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute_all test, matcher, _stdout, _stderr, _stdboth, _status, env
Method execute_size
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute_size test, matcher, _stdout, _stderr, _stdboth, _status, env
Method execute
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute test, _stdout, _stderr, _stdboth, _status, env
Method execute
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute test, _stdout, _stderr, _stdboth, _status, env
Method execute
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute test, _stdout, _stderr, _stdboth, _status, env
Method execute
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute test, _stdout, _stderr, _stdboth, _status, env
Method execute
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def execute test, _stdout, _stderr, _stdboth, _status, env
Method process_command_tests
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def process_command_tests _stdout, _stderr, _stdboth, _status, env, tests
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ( sign == "=" ) ^ ( Regexp.new(value) =~ "#{var_val}" )
[ false, "failed: env #{variable}[] #{sign} /#{value}/ # was '#{var_val}'" ]
else
[ true, "passed: env #{variable}[] #{sign} /#{value}/" ]
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 39.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
def start_test test, env
@counts[:commands] += test[:commands].size
tests_counts = test[:commands].map{|line| line[:tests].nil? ? 0 : line[:tests].size }
@counts[:tests] += tests_counts.empty? ? 0 : tests_counts.inject(&:+)
end
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 39.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
def start_test test, env
@counts[:commands] += test[:commands].size
tests_counts = test[:commands].map{|line| line[:tests].nil? ? 0 : line[:tests].size }
@counts[:tests] += tests_counts.empty? ? 0 : tests_counts.inject(&:+)
end
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 39.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76