mperham/dalli

View on GitHub
lib/dalli/client.rb

Summary

Maintainability
D
2 days
Test Coverage

Method get_multi_yielder has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def get_multi_yielder(keys)
      perform do
        return {} if keys.empty?
        ring.lock do
          begin
Severity: Minor
Found in lib/dalli/client.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Client has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client

    ##
    # Dalli::Client is the main class which developers will use to interact with
    # the memcached server.  Usage:
Severity: Minor
Found in lib/dalli/client.rb - About 5 hrs to fix

    File client.rb has 292 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'digest/md5'
    require 'set'
    
    # encoding: ascii
    module Dalli
    Severity: Minor
    Found in lib/dalli/client.rb - About 3 hrs to fix

      Method get_multi_yielder has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def get_multi_yielder(keys)
            perform do
              return {} if keys.empty?
              ring.lock do
                begin
      Severity: Minor
      Found in lib/dalli/client.rb - About 1 hr to fix

        Method fetch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def fetch(key, ttl=nil, options=nil)
              options = options.nil? ? CACHE_NILS : options.merge(CACHE_NILS) if @options[:cache_nils]
              val = get(key, options)
              not_found = @options[:cache_nils] ?
                val == Dalli::Server::NOT_FOUND :
        Severity: Minor
        Found in lib/dalli/client.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method perform_multi_response_start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def perform_multi_response_start(servers)
              servers.each do |server|
                next unless server.alive?
                begin
                  server.multi_response_start
        Severity: Minor
        Found in lib/dalli/client.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def decr(key, amt=1, ttl=nil, default=nil)
              raise ArgumentError, "Positive values only: #{amt}" if amt < 0
              perform(:decr, key, amt.to_i, ttl_or_default(ttl), default)
        Severity: Minor
        Found in lib/dalli/client.rb and 1 other location - About 15 mins to fix
        lib/dalli/client.rb on lines 185..187

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def incr(key, amt=1, ttl=nil, default=nil)
              raise ArgumentError, "Positive values only: #{amt}" if amt < 0
              perform(:incr, key, amt.to_i, ttl_or_default(ttl), default)
        Severity: Minor
        Found in lib/dalli/client.rb and 1 other location - About 15 mins to fix
        lib/dalli/client.rb on lines 204..206

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status