mperham/dalli

View on GitHub
lib/dalli/ring.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method server_for_key has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def server_for_key(key)
      if @continuum
        hkey = hash_for(key)
        20.times do |try|
          entryidx = binary_search(@continuum, hkey)
Severity: Minor
Found in lib/dalli/ring.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method binary_search has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def binary_search(ary, value)
        upper = ary.size - 1
        lower = 0

        while (lower <= upper) do
Severity: Minor
Found in lib/dalli/ring.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status