mperham/dalli

View on GitHub
lib/rack/session/dalli.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method extract_dalli_options has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def extract_dalli_options(options)
        return [options[:cache]] if options[:cache]

        # Filter out Rack::Session-specific options and apply our defaults
        mopts = DEFAULT_DALLI_OPTIONS.merge \
Severity: Minor
Found in lib/rack/session/dalli.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method with_block has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def with_block(env, default=nil, &block)
        @mutex.lock if @mutex and env['rack.multithread']
        @pool.with(&block)
      rescue ::Dalli::DalliError, Errno::ECONNREFUSED
        raise if $!.message =~ /undefined class/
Severity: Minor
Found in lib/rack/session/dalli.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_session has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def get_session(env, sid)
        with_block(env, [nil, {}]) do |dc|
          unless sid and !sid.empty? and session = dc.get(sid)
            old_sid, sid, session = sid, generate_sid_with(dc), {}
            unless dc.add(sid, session, @default_ttl)
Severity: Minor
Found in lib/rack/session/dalli.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status