mperham/sidekiq

View on GitHub
lib/sidekiq/web/helpers.rb

Summary

Maintainability
A
3 hrs
Test Coverage

File helpers.rb has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "uri"
require "set"
require "yaml"
require "cgi"

Severity: Minor
Found in lib/sidekiq/web/helpers.rb - About 2 hrs to fix

    Method user_preferred_languages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def user_preferred_languages
          languages = env["HTTP_ACCEPT_LANGUAGE"]
          languages.to_s.downcase.gsub(/\s+/, "").split(",").map { |language|
            locale, quality = language.split(";q=", 2)
            locale = nil if locale == "*" # Ignore wildcards
    Severity: Minor
    Found in lib/sidekiq/web/helpers.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method poll_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def poll_path
          if current_path != "" && params["poll"]
            path = root_path + current_path
            query_string = to_query_string(params.slice(*params.keys - %w[page poll]))
            path += "?#{query_string}" unless query_string.empty?
    Severity: Minor
    Found in lib/sidekiq/web/helpers.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status