src/TerytSoapClient.php
Method __doRequest
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public function __doRequest($request, $location, $action, $version, $oneWay = 0)
Missing class import via use statement (line '60', column '20'). Open
Open
$doc = new \DOMDocument('1.0');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method addUserToken has a boolean flag argument $digest, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function addUserToken(string $username, string $password, bool $digest = false): void
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}