Sign upLogin

mrcnpdlk/teryt-api

View on GitHub
Star
src/TerytSoapClient.php

Summary

Maintainability
A
35 mins
Test Coverage

Method __doRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __doRequest($request, $location, $action, $version, $oneWay = 0)
Severity: Minor
Found in src/TerytSoapClient.php - About 35 mins to fix

    Missing class import via use statement (line '60', column '20').
    Open

            $doc = new \DOMDocument('1.0');
    Severity: Minor
    Found in src/TerytSoapClient.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method addUserToken has a boolean flag argument $digest, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function addUserToken(string $username, string $password, bool $digest = false): void
    Severity: Minor
    Found in src/TerytSoapClient.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    There are no issues that match your filters.

    Category
    Status