Sign upLogin

mschnee/mister

View on GitHub
Star
src/lib/App/App.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function packCommand has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public packCommand() {
        const mrjson = this.packageManager.getMonorepoPjson();
        const manifestFile = {
            packages: {},
            version:  mrjson.version,
Severity: Minor
Found in src/lib/App/App.ts - About 1 hr to fix

    Function doTasksOnAll has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public doTasksOnAll(packages: string[]) {
        return packages.reduce((accum, packageName) => {
            const tasks  = this.packageManager.getMatchingPackageTasks(packageName, this.args.tasks || this.args._)
            return tasks.reduce((a: any, task) => {
                return a.then(async (previousSuccess) => {
    Severity: Minor
    Found in src/lib/App/App.ts - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              if (process.env.hasOwnProperty('Path')) {
            spawnOptions.env.Path = `${process.env.Path}${path.delimiter}${localBin}`;
        }
      Severity: Major
      Found in src/lib/App/App.ts and 3 other locations - About 40 mins to fix
      src/lib/App/App.ts on lines 144..146
      src/lib/PackageManager/PackageManager.ts on lines 323..325
      src/lib/PackageManager/PackageManager.ts on lines 328..330

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              if (process.env.hasOwnProperty('PATH')) {
            spawnOptions.env.PATH = `${process.env.PATH}${path.delimiter}${localBin}`;
        }
      Severity: Major
      Found in src/lib/App/App.ts and 3 other locations - About 40 mins to fix
      src/lib/App/App.ts on lines 150..152
      src/lib/PackageManager/PackageManager.ts on lines 323..325
      src/lib/PackageManager/PackageManager.ts on lines 328..330

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (this.verbosity >= 1) {
            /* tslint:disable-next-line */
            console.log(wrap('[]', packageName), 'created', chalk.bold.green(shortName));
        }
      Severity: Minor
      Found in src/lib/App/App.ts and 1 other location - About 35 mins to fix
      src/lib/App/App.ts on lines 116..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (this.verbosity >= 1) {
                    /* tslint:disable-next-line */
                    console.log(wrap('[]', packageName), 'created', chalk.bold.green(distFileLocation));
                }
      Severity: Minor
      Found in src/lib/App/App.ts and 1 other location - About 35 mins to fix
      src/lib/App/App.ts on lines 223..226

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status