mtxr/vscode-sqltools

View on GitHub

Showing 104 of 104 total issues

Function getStatements has a Cognitive Complexity of 62 (exceeds 15 allowed). Consider refactoring.
Open

  static getStatements(query: string, driver: string, delimiter: string): Array<string> {
    var charArray: Array<string> = Array.from(query);
    var previousChar: string = null;
    var nextChar: string = null;
    var isInComment: boolean = false;
Severity: Minor
Found in packages/core/utils/query/parse.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

ConnectionManagerPlugin has 46 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin {
  public client: SQLTools.LanguageClientInterface;
  public resultsWebview: ResultsWebviewManager;
  public settingsWebview: SettingsWebview;
  private context: ExtensionContext;
Severity: Minor
Found in packages/plugins/connection-manager/extension.ts - About 6 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      public getTables(cached: boolean = false): Promise<DatabaseInterface.Table[]> {
        if (cached && this.tables.length > 0) {
          return Promise.resolve(this.tables);
        }
        return this.conn.getTables().then((tables: DatabaseInterface.Table[]) => {
    Severity: Major
    Found in packages/core/connection.ts and 2 other locations - About 5 hrs to fix
    packages/core/connection.ts on lines 72..80
    packages/core/connection.ts on lines 82..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      public getColumns(cached: boolean = false): Promise<DatabaseInterface.TableColumn[]> {
        if (cached && this.columns.length > 0) {
          return Promise.resolve(this.columns);
        }
        return this.conn.getColumns().then((columns: DatabaseInterface.TableColumn[]) => {
    Severity: Major
    Found in packages/core/connection.ts and 2 other locations - About 5 hrs to fix
    packages/core/connection.ts on lines 62..70
    packages/core/connection.ts on lines 82..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      public getFunctions(cached: boolean = false): Promise<DatabaseInterface.Function[]> {
        if (cached && this.columns.length > 0) {
          return Promise.resolve(this.functions);
        }
        return this.conn.getFunctions().then((functions: DatabaseInterface.Function[]) => {
    Severity: Major
    Found in packages/core/connection.ts and 2 other locations - About 5 hrs to fix
    packages/core/connection.ts on lines 62..70
    packages/core/connection.ts on lines 72..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 143.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        return this.query(this.queries.fetchTables)
          .then(([queryRes]) => {
            return queryRes.results
              .reduce((prev, curr) => prev.concat(curr), [])
              .map((obj) => {
    Severity: Major
    Found in packages/drivers/oracle/index.ts and 1 other location - About 5 hrs to fix
    packages/drivers/saphana/index.ts on lines 157..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        return this.query(this.queries.fetchTables, [this.schema, this.schema])
          .then(([queryRes]) => {
            return queryRes.results
              .reduce((prev, curr) => prev.concat(curr), [])
              .map((obj) => {
    Severity: Major
    Found in packages/drivers/saphana/index.ts and 1 other location - About 5 hrs to fix
    packages/drivers/oracle/index.ts on lines 132..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        return commands.executeCommand(`${EXT_NAME}.updateConnection`, editId, connInfo, globalSetting ? 'Global' : undefined)
        .then(() => {
          this.postMessage({ action: 'updateConnectionSuccess', payload: { globalSetting, connInfo: { ...connInfo, id: getConnectionId(connInfo) } } });
        }, (payload = {}) => {
            payload = {
    Severity: Major
    Found in packages/plugins/connection-manager/screens/settings.ts and 1 other location - About 4 hrs to fix
    packages/plugins/connection-manager/screens/settings.ts on lines 54..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        return commands.executeCommand(`${EXT_NAME}.addConnection`, connInfo, globalSetting ? 'Global' : undefined)
        .then(() => {
          this.postMessage({ action: 'createConnectionSuccess', payload: { globalSetting, connInfo: { ...connInfo, id: getConnectionId(connInfo) } } });
        }, (payload = {}) => {
            payload = {
    Severity: Major
    Found in packages/plugins/connection-manager/screens/settings.ts and 1 other location - About 4 hrs to fix
    packages/plugins/connection-manager/screens/settings.ts on lines 39..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const Button = styled.button<{ fg?: string; bg?: string; float?: 'right' | 'left' }>`
      ${common}
      float: ${p => p.float};
      color: ${p => p.fg || 'white'};
      background: ${p => p.bg || 'var(--vscode-editorLink-activeForeground)'};
    Severity: Major
    Found in packages/ui/components/Button.tsx and 1 other location - About 4 hrs to fix
    packages/ui/components/Button.tsx on lines 11..19

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const A = styled.a<{ fg?: string; bg?: string; float?: 'right' | 'left' }>`
      ${common}
      float: ${p => p.float};
      color: ${p => p.fg || 'white'};
      background: ${p => p.bg || 'var(--vscode-editorLink-activeForeground)'};
    Severity: Major
    Found in packages/ui/components/Button.tsx and 1 other location - About 4 hrs to fix
    packages/ui/components/Button.tsx on lines 20..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getStatements has 107 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      static getStatements(query: string, driver: string, delimiter: string): Array<string> {
        var charArray: Array<string> = Array.from(query);
        var previousChar: string = null;
        var nextChar: string = null;
        var isInComment: boolean = false;
    Severity: Major
    Found in packages/core/utils/query/parse.ts - About 3 hrs to fix

      Function getWebviewConfig has 93 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      module.exports = exports = function getWebviewConfig() {
        return {
          name: 'ui',
          entry: {
            Settings: path.join(__dirname, 'screens', 'Settings.tsx'),
      Severity: Major
      Found in packages/ui/webpack.config.js - About 2 hrs to fix

        Connection has 24 functions (exceeds 20 allowed). Consider refactoring.
        Open

        export default class Connection {
          private tables: DatabaseInterface.Table[] = [];
          private columns: DatabaseInterface.TableColumn[] = [];
          private functions: DatabaseInterface.Function[] = [];
          private connected: boolean = false;
        Severity: Minor
        Found in packages/core/connection.ts - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            private _updateSidebar({
              conn,
              tables,
              columns,
              functions
          Severity: Major
          Found in packages/plugins/connection-manager/language-server.ts and 1 other location - About 2 hrs to fix
          packages/plugins/connection-manager/explorer/index.ts on lines 160..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            public setTreeData = ({
              conn,
              tables,
              columns,
              functions
          Severity: Major
          Found in packages/plugins/connection-manager/explorer/index.ts and 1 other location - About 2 hrs to fix
          packages/plugins/connection-manager/language-server.ts on lines 289..303

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          SQLToolsLanguageServer has 22 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SQLToolsLanguageServer implements SQLTools.LanguageServerInterface {
            private _server: IConnection;
            private _docManager = new TextDocuments();
            private onInitializeHooks: Arg0<IConnection['onInitialize']>[] = [];
            private onInitializedHooks: Arg0<IConnection['onInitialized']>[] = [];
          Severity: Minor
          Found in packages/language-server/server.ts - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              DB2: {
                port: 50000,
                value: DatabaseDriver['DB2'],
                icon: getIconPathForDriver(DatabaseDriver['DB2']),
                text: 'DB2 (Node Native)',
            Severity: Major
            Found in packages/ui/screens/Settings/lib/availableDrivers.ts and 1 other location - About 2 hrs to fix
            packages/ui/screens/Settings/lib/availableDrivers.ts on lines 106..119

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              OracleDB: {
                port: 1521,
                value: DatabaseDriver['OracleDB'],
                icon: getIconPathForDriver(DatabaseDriver['OracleDB']),
                text: 'OracleDB (Node Native)',
            Severity: Major
            Found in packages/ui/screens/Settings/lib/availableDrivers.ts and 1 other location - About 2 hrs to fix
            packages/ui/screens/Settings/lib/availableDrivers.ts on lines 43..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  case MenuActions.SaveJSONOption:
                    getVscode().postMessage({
                      action: 'call',
                      payload: {
                        command: `${process.env.EXT_NAME}.saveResults`,
            Severity: Major
            Found in packages/ui/screens/Results/ResultsTable.tsx and 1 other location - About 1 hr to fix
            packages/ui/screens/Results/ResultsTable.tsx on lines 215..223

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language