mtxr/vscode-sqltools

View on GitHub

Showing 76 of 77 total issues

Function getStatements has a Cognitive Complexity of 62 (exceeds 15 allowed). Consider refactoring.
Open

  static getStatements(query: string, dialect: string, delimiter: string): Array<string> {
    var charArray: Array<string> = Array.from(query);
    var previousChar: string = null;
    var nextChar: string = null;
    var isInComment: boolean = false;
Severity: Minor
Found in packages/core/utils/query/parse.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

          case ConnectionMethod.ConnectionString:
            newState.fields.server.visible = false;
            newState.fields.port.visible = false;
            newState.fields.database.visible = false;
            newState.fields.username.visible = false;
Severity: Major
Found in packages/ui/screens/Settings/Screen.tsx and 2 other locations - About 6 hrs to fix
packages/ui/screens/Settings/Screen.tsx on lines 232..241
packages/ui/screens/Settings/Screen.tsx on lines 242..251

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

          case ConnectionMethod.Socket:
            newState.fields.server.visible = false;
            newState.fields.port.visible = false;
            newState.fields.database.visible = true;
            newState.fields.username.visible = true;
Severity: Major
Found in packages/ui/screens/Settings/Screen.tsx and 2 other locations - About 6 hrs to fix
packages/ui/screens/Settings/Screen.tsx on lines 222..231
packages/ui/screens/Settings/Screen.tsx on lines 242..251

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

          case ConnectionMethod.ServerAndPort:
            newState.fields.server.visible = true;
            newState.fields.port.visible = true;
            newState.fields.socketPath.visible = false;
            newState.fields.connectString.visible = false;
Severity: Major
Found in packages/ui/screens/Settings/Screen.tsx and 2 other locations - About 6 hrs to fix
packages/ui/screens/Settings/Screen.tsx on lines 222..231
packages/ui/screens/Settings/Screen.tsx on lines 232..241

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

ConnectionManagerPlugin has 41 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin {
  public client: SQLTools.LanguageClientInterface;
  public resultsWebview: ResultsWebviewManager;
  public settingsWebview: SettingsWebview;
  public statusBar: StatusBarItem;;
Severity: Minor
Found in packages/plugins/connection-manager/extension.ts - About 5 hrs to fix

    Function render has 161 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      public render() {
        const formFields = this.getVisibleFields()
        .map((f, i) => {
          const field = this.state.fields[f];
          let formField;
    Severity: Major
    Found in packages/ui/screens/Settings/Screen.tsx - About 5 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public getColumns(cached: boolean = false): Promise<DatabaseInterface.TableColumn[]> {
          if (cached && this.columns.length > 0) {
            return Promise.resolve(this.columns);
          }
          return this.conn.getColumns().then((columns: DatabaseInterface.TableColumn[]) => {
      Severity: Major
      Found in packages/core/connection.ts and 2 other locations - About 5 hrs to fix
      packages/core/connection.ts on lines 58..66
      packages/core/connection.ts on lines 78..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public getTables(cached: boolean = false): Promise<DatabaseInterface.Table[]> {
          if (cached && this.tables.length > 0) {
            return Promise.resolve(this.tables);
          }
          return this.conn.getTables().then((tables: DatabaseInterface.Table[]) => {
      Severity: Major
      Found in packages/core/connection.ts and 2 other locations - About 5 hrs to fix
      packages/core/connection.ts on lines 68..76
      packages/core/connection.ts on lines 78..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        public getFunctions(cached: boolean = false): Promise<DatabaseInterface.Function[]> {
          if (cached && this.columns.length > 0) {
            return Promise.resolve(this.functions);
          }
          return this.conn.getFunctions().then((functions: DatabaseInterface.Function[]) => {
      Severity: Major
      Found in packages/core/connection.ts and 2 other locations - About 5 hrs to fix
      packages/core/connection.ts on lines 58..66
      packages/core/connection.ts on lines 68..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          return this.query(this.queries.fetchTables, [this.schema])
            .then(([queryRes]) => {
              return queryRes.results
                .reduce((prev, curr) => prev.concat(curr), [])
                .map((obj) => {
      Severity: Major
      Found in packages/core/dialect/saphana/index.ts and 1 other location - About 5 hrs to fix
      packages/core/dialect/oracle/index.ts on lines 131..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 140.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          return this.query(this.queries.fetchTables)
            .then(([queryRes]) => {
              return queryRes.results
                .reduce((prev, curr) => prev.concat(curr), [])
                .map((obj) => {
      Severity: Major
      Found in packages/core/dialect/oracle/index.ts and 1 other location - About 5 hrs to fix
      packages/core/dialect/saphana/index.ts on lines 154..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 140.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          commands.executeCommand(`${EXT_NAME}.updateConnection`, editId, connInfo, isGlobal ? 'Global' : undefined)
          .then(() => {
            this.postMessage({ action: 'updateConnectionSuccess', payload: { isGlobal, connInfo: { ...connInfo, id: getConnectionId(connInfo) } } });
          }, (payload = {}) => {
              payload = {
      Severity: Major
      Found in packages/plugins/connection-manager/screens/settings.ts and 1 other location - About 4 hrs to fix
      packages/plugins/connection-manager/screens/settings.ts on lines 60..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          commands.executeCommand(`${EXT_NAME}.addConnection`, connInfo, isGlobal ? 'Global' : undefined)
          .then(() => {
            this.postMessage({ action: 'createConnectionSuccess', payload: { isGlobal, connInfo: { ...connInfo, id: getConnectionId(connInfo) } } });
          }, (payload = {}) => {
              payload = {
      Severity: Major
      Found in packages/plugins/connection-manager/screens/settings.ts and 1 other location - About 4 hrs to fix
      packages/plugins/connection-manager/screens/settings.ts on lines 44..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      OutputChannelLogger has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class OutputChannelLogger implements Console {
        private prefix = (type: string) => {
          return `${type}:`;
        }
        Console: NodeJS.ConsoleConstructor;
      Severity: Minor
      Found in packages/core/log/vscode.ts - About 3 hrs to fix

        Function getStatements has 107 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

          static getStatements(query: string, dialect: string, delimiter: string): Array<string> {
            var charArray: Array<string> = Array.from(query);
            var previousChar: string = null;
            var nextChar: string = null;
            var isInComment: boolean = false;
        Severity: Major
        Found in packages/core/utils/query/parse.ts - About 3 hrs to fix

          Function render has a Cognitive Complexity of 33 (exceeds 15 allowed). Consider refactoring.
          Open

            public render() {
              const formFields = this.getVisibleFields()
              .map((f, i) => {
                const field = this.state.fields[f];
                let formField;
          Severity: Minor
          Found in packages/ui/screens/Settings/Screen.tsx - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Connection has 23 functions (exceeds 20 allowed). Consider refactoring.
          Open

          export default class Connection {
            private tables: DatabaseInterface.Table[] = [];
            private columns: DatabaseInterface.TableColumn[] = [];
            private functions: DatabaseInterface.Function[] = [];
            private connected: boolean = false;
          Severity: Minor
          Found in packages/core/connection.ts - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              private _updateSidebar({
                conn,
                tables,
                columns,
                functions
            Severity: Major
            Found in packages/plugins/connection-manager/language-server.ts and 1 other location - About 2 hrs to fix
            packages/plugins/connection-manager/explorer/index.ts on lines 106..137

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              public setTreeData = ({
                conn,
                tables,
                columns,
                functions
            Severity: Major
            Found in packages/plugins/connection-manager/explorer/index.ts and 1 other location - About 2 hrs to fix
            packages/plugins/connection-manager/language-server.ts on lines 196..210

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            SQLToolsLanguageServer has 22 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class SQLToolsLanguageServer implements SQLTools.LanguageServerInterface {
              private _telemetry = new Telemetry({
                enableTelemetry: false,
                product: 'language-server',
              });
            Severity: Minor
            Found in packages/language-server/server.ts - About 2 hrs to fix
              Severity
              Category
              Status
              Source
              Language