mtxr/vscode-sqltools

View on GitHub
packages/core/utils/query/parse.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getStatements has a Cognitive Complexity of 62 (exceeds 15 allowed). Consider refactoring.
Open

  static getStatements(query: string, driver: string, delimiter: string): Array<string> {
    var charArray: Array<string> = Array.from(query);
    var previousChar: string = null;
    var nextChar: string = null;
    var isInComment: boolean = false;
Severity: Minor
Found in packages/core/utils/query/parse.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getStatements has 107 lines of code (exceeds 50 allowed). Consider refactoring.
Open

  static getStatements(query: string, driver: string, delimiter: string): Array<string> {
    var charArray: Array<string> = Array.from(query);
    var previousChar: string = null;
    var nextChar: string = null;
    var isInComment: boolean = false;
Severity: Major
Found in packages/core/utils/query/parse.ts - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

          if (
            ((char == '#' && nextChar == ' ') || (char == '-' && nextChar == '-') || (char == '/' && nextChar == '*')) &&
            isInString == false
          ) {
            isInComment = true;
    Severity: Major
    Found in packages/core/utils/query/parse.ts - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

            if (
              isInComment == true &&
              (((commentChar == '#' || commentChar == '-') && char == '\n') ||
                (commentChar == '/' && (char == '*' && nextChar == '/')))
            ) {
      Severity: Major
      Found in packages/core/utils/query/parse.ts - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    if (tagSymbol == tagChar) {
                      isInTag = false;
                    }
        Severity: Major
        Found in packages/core/utils/query/parse.ts - About 45 mins to fix

          Consider simplifying this complex logical expression.
          Open

                if (
                  driver === 'mssql'
                  && char.toLowerCase() === 'g'
                  && `${charArray[index + 1] || ''}`.toLowerCase() === 'o'
                  && (
          Severity: Major
          Found in packages/core/utils/query/parse.ts - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                  if ((char == '#' && nextChar == ' ') || (char == '-' && nextChar == '-') || (char == '/' && nextChar == '*')) {
                    break;
                  } else {
                    if (clearedText == null) {
                      clearedText = '';
            Severity: Major
            Found in packages/core/utils/query/parse.ts - About 40 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if ((char == '#' && nextChar == ' ') || (char == '-' && nextChar == '-') || (char == '/' && nextChar == '*')) {
              Severity: Minor
              Found in packages/core/utils/query/parse.ts and 1 other location - About 30 mins to fix
              packages/core/utils/query/parse.ts on lines 65..65

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      ((char == '#' && nextChar == ' ') || (char == '-' && nextChar == '-') || (char == '/' && nextChar == '*')) &&
              Severity: Minor
              Found in packages/core/utils/query/parse.ts and 1 other location - About 30 mins to fix
              packages/core/utils/query/parse.ts on lines 246..246

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status