mtxr/vscode-sqltools

View on GitHub
packages/extension/language-client/client.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getClientOptions has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

  private getClientOptions(): LanguageClientOptions {
    const telemetryArgs: ITelemetryArgs = {
      enableTelemetry: workspace.getConfiguration().get('telemetry.enableTelemetry') || false,
      extraInfo: {
        sessId: VSCodeEnv.sessionId,
Severity: Major
Found in packages/extension/language-client/client.ts - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      public sendNotification: LanguageClient['sendNotification'] = async function () {
        await this.client.onReady();
        return this.client.sendNotification.apply(this.client, arguments);
      }
    Severity: Major
    Found in packages/extension/language-client/client.ts and 3 other locations - About 1 hr to fix
    packages/extension/language-client/client.ts on lines 68..71
    packages/extension/language-client/client.ts on lines 73..76
    packages/extension/language-client/client.ts on lines 82..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      public sendRequest: LanguageClient['sendRequest'] = async function () {
        await this.client.onReady();
        return this.client.sendRequest.apply(this.client, arguments);
      }
    Severity: Major
    Found in packages/extension/language-client/client.ts and 3 other locations - About 1 hr to fix
    packages/extension/language-client/client.ts on lines 73..76
    packages/extension/language-client/client.ts on lines 78..81
    packages/extension/language-client/client.ts on lines 82..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      public onRequest: LanguageClient['onRequest'] = async function () {
        await this.client.onReady();
        return this.client.onRequest.apply(this.client, arguments);
      }
    Severity: Major
    Found in packages/extension/language-client/client.ts and 3 other locations - About 1 hr to fix
    packages/extension/language-client/client.ts on lines 68..71
    packages/extension/language-client/client.ts on lines 78..81
    packages/extension/language-client/client.ts on lines 82..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      public onNotification: LanguageClient['onNotification'] = async function () {
        await this.client.onReady();
        return this.client.onNotification.apply(this.client, arguments);
      }
    Severity: Major
    Found in packages/extension/language-client/client.ts and 3 other locations - About 1 hr to fix
    packages/extension/language-client/client.ts on lines 68..71
    packages/extension/language-client/client.ts on lines 73..76
    packages/extension/language-client/client.ts on lines 78..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          if (event.affectsConfig('languageServerEnv')) {
            const res = await window.showWarningMessage('New language server environment variables set. You must reload window to take effect.', 'Reload now');
            if (!res) return;
            commands.executeCommand('workbench.action.reloadWindow');
          }
    Severity: Minor
    Found in packages/extension/language-client/client.ts and 1 other location - About 50 mins to fix
    packages/extension/language-client/client.ts on lines 50..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          if (event.affectsConfig('useNodeRuntime')) {
            const res = await window.showWarningMessage('Use node runtime setting change. You must reload window to take effect.', 'Reload now');
            if (!res) return;
            commands.executeCommand('workbench.action.reloadWindow');
          }
    Severity: Minor
    Found in packages/extension/language-client/client.ts and 1 other location - About 50 mins to fix
    packages/extension/language-client/client.ts on lines 56..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status