Sign upLogin

musaffa/file_validators

View on GitHub
Star

Showing 4 of 4 total issues

Method extract_with_file has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def extract_with_file(io)
      require 'open3'

      return nil if io.eof? # file command returns "application/x-empty" for empty files
Severity: Minor
Found in lib/file_validators/mime_type_analyzer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_errors has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def check_errors(record, attribute, values, option, option_value)
Severity: Minor
Found in lib/file_validators/validators/file_size_validator.rb - About 35 mins to fix

    Method check_validity! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_validity!
        unless (CHECKS & options.keys).present?
          raise ArgumentError, 'You must at least pass in :allow or :exclude option'
        end
    Severity: Minor
    Found in lib/file_validators/validators/file_content_type_validator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_values has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse_values(value)
        return [] unless value.present?

        value = JSON.parse(value) if value.is_a?(String)
        return [] unless value.present?
    Severity: Minor
    Found in lib/file_validators/validators/file_size_validator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language