Showing 13 of 94 total issues
Method has too many lines. [15/10] Open
def custom_caps(text)
# $1 and $2 are excluded HTML tags, $3 is the part before the caps and $4 is the caps match
text.gsub(%r{
(<[^/][^>]*?>)| # Ignore any opening tag, so we don't mess up attribute values
(\s| |^|'|"|>|) # Make sure our capture is preceded by whitespace or quotes
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Jekyll::TypogrifyFilter has no descriptive comment Open
module TypogrifyFilter
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.
Example
Given
class Dummy
# Do things...
end
Reek would emit the following warning:
test.rb -- 1 warning:
[1]:Dummy has no descriptive comment (IrresponsibleModule)
Fixing this is simple - just an explaining comment:
# The Dummy class is responsible for ...
class Dummy
# Do things...
end
Jekyll::TypogrifyFilter#amp doesn't depend on instance state (maybe move it to another class?) Open
def amp(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#initial_quotes doesn't depend on instance state (maybe move it to another class?) Open
def initial_quotes(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#titlecase doesn't depend on instance state (maybe move it to another class?) Open
def titlecase(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#entities doesn't depend on instance state (maybe move it to another class?) Open
def entities(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#widont doesn't depend on instance state (maybe move it to another class?) Open
def widont(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#emdash doesn't depend on instance state (maybe move it to another class?) Open
def emdash(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#smartypants doesn't depend on instance state (maybe move it to another class?) Open
def smartypants(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#letter_spacing doesn't depend on instance state (maybe move it to another class?) Open
def letter_spacing(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#improve doesn't depend on instance state (maybe move it to another class?) Open
def improve(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#custom_caps doesn't depend on instance state (maybe move it to another class?) Open
def custom_caps(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Jekyll::TypogrifyFilter#caps doesn't depend on instance state (maybe move it to another class?) Open
def caps(text)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.