Sign upLogin

myronmarston/vcr

View on GitHub
Star
lib/vcr/library_hooks/fakeweb.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method request_with_vcr has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def request_with_vcr(request, *args, &block)
        if VCR.turned_on?
          handler = request.instance_eval do
            remove_instance_variable(:@__vcr_request_handler) if defined?(@__vcr_request_handler)
          end || VCR::LibraryHooks::FakeWeb::RequestHandler.new(self, request, *args, &block)
Severity: Minor
Found in lib/vcr/library_hooks/fakeweb.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(request_type, stubbed_response, vcr_request, *args, &response_block)
Severity: Minor
Found in lib/vcr/library_hooks/fakeweb.rb - About 35 mins to fix

    Method perform_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def perform_request(started, record_interaction = false)
          # Net::HTTP calls #request recursively in certain circumstances.
          # We only want to record the request when the request is started, as
          # that is the final time through #request.
          unless started
    Severity: Minor
    Found in lib/vcr/library_hooks/fakeweb.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status