Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/assets/javascripts/alaveteli_pro/stripe.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function stripeForm has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function stripeForm(form, options) {
  var that = Object.assign({
    stripe: Stripe(AlaveteliPro.stripe_publishable_key),
    form: form,
    submit: document.getElementById('js-stripe-submit'),
Severity: Major
Found in app/assets/javascripts/alaveteli_pro/stripe.js - About 3 hrs to fix

    Function stripeForm has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function stripeForm(form, options) {
  var that = Object.assign({
    stripe: Stripe(AlaveteliPro.stripe_publishable_key),
    form: form,
    submit: document.getElementById('js-stripe-submit'),
    Severity: Minor
    Found in app/assets/javascripts/alaveteli_pro/stripe.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function load has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      that.load = function() {
    var cardError = document.getElementById('card-errors');

    // Sync initial state for terms checkbox and submit button
    that.submit.setAttribute('disabled', 'true');
    Severity: Minor
    Found in app/assets/javascripts/alaveteli_pro/stripe.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status