Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/controllers/admin_incoming_message_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method redeliver has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def redeliver
    message_ids = params[:url_title].split(',').map(&:strip)
    previous_request = @incoming_message.info_request
    destination_request = nil
Severity: Minor
Found in app/controllers/admin_incoming_message_controller.rb - About 1 hr to fix

    Method bulk_destroy has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def bulk_destroy
    if params[:commit] == "No"
      redirect_to(admin_request_url(params[:request_id]))
    end
    Severity: Minor
    Found in app/controllers/admin_incoming_message_controller.rb - About 1 hr to fix

      Method redeliver has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def redeliver
    message_ids = params[:url_title].split(',').map(&:strip)
    previous_request = @incoming_message.info_request
    destination_request = nil
      Severity: Minor
      Found in app/controllers/admin_incoming_message_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method bulk_destroy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def bulk_destroy
    if params[:commit] == "No"
      redirect_to(admin_request_url(params[:request_id]))
    end
      Severity: Minor
      Found in app/controllers/admin_incoming_message_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status