Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/controllers/api_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method add_correspondence has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def add_correspondence
    json = ActiveSupport::JSON.decode(params[:correspondence_json])
    attachments = params[:attachments]

    direction = json["direction"]
Severity: Major
Found in app/controllers/api_controller.rb - About 2 hrs to fix

    Method body_request_events has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def body_request_events
    feed_type = params[:feed_type]
    if @public_body.id != params[:id].to_i
      raise PermissionDenied, "#{@public_body.id} != #{params[:id]}"
    end
    Severity: Major
    Found in app/controllers/api_controller.rb - About 2 hrs to fix

      Method add_correspondence has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def add_correspondence
    json = ActiveSupport::JSON.decode(params[:correspondence_json])
    attachments = params[:attachments]

    direction = json["direction"]
      Severity: Minor
      Found in app/controllers/api_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method body_request_events has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def body_request_events
    feed_type = params[:feed_type]
    if @public_body.id != params[:id].to_i
      raise PermissionDenied, "#{@public_body.id} != #{params[:id]}"
    end
      Severity: Minor
      Found in app/controllers/api_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_request has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create_request
    json = ActiveSupport::JSON.decode(params[:request_json])
    request = InfoRequest.new(
      title: json["title"],
      public_body_id: @public_body.id,
      Severity: Minor
      Found in app/controllers/api_controller.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status