Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/controllers/services_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method other_country_message has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def other_country_message
    flash.keep

    text = ""
    site_country_code = AlaveteliConfiguration.iso_country_code.downcase
Severity: Minor
Found in app/controllers/services_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method other_country_message has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def other_country_message
    flash.keep

    text = ""
    site_country_code = AlaveteliConfiguration.iso_country_code.downcase
Severity: Minor
Found in app/controllers/services_controller.rb - About 1 hr to fix

    Method hidden_user_explanation has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def hidden_user_explanation
    prominence_reason = render_to_string(
      partial: "admin_request/hidden_user_explanation/#{params[:message]}",
      formats: [:text],
      locals: {
    Severity: Minor
    Found in app/controllers/services_controller.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status