Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/mailers/request_mailer.rb

Summary

Maintainability
D
2 days
Test Coverage

File request_mailer.rb has 411 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class RequestMailer < ApplicationMailer
  include AlaveteliFeatures::Helpers

  before_action :set_footer_template,
                only: [
Severity: Minor
Found in app/mailers/request_mailer.rb - About 5 hrs to fix

    Method alert_comment_on_request has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.alert_comment_on_request
    # We only check comments made in the last month - this means if the
    # cron jobs broke for more than a month events would be lost, but no
    # matter. I suspect the performance gain will be needed (with an index on updated_at)
    Severity: Minor
    Found in app/mailers/request_mailer.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method alert_overdue_requests has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.alert_overdue_requests
    info_requests = InfoRequest.where("described_state = 'waiting_response'
                AND awaiting_description = ?
                AND user_id is not null
                AND use_notifications = ?
    Severity: Minor
    Found in app/mailers/request_mailer.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method alert_overdue_requests has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.alert_overdue_requests
    info_requests = InfoRequest.where("described_state = 'waiting_response'
                AND awaiting_description = ?
                AND user_id is not null
                AND use_notifications = ?
    Severity: Major
    Found in app/mailers/request_mailer.rb - About 2 hrs to fix

      Class RequestMailer has 22 methods (exceeds 20 allowed). Consider refactoring.
      Wontfix

      class RequestMailer < ApplicationMailer
  include AlaveteliFeatures::Helpers

  before_action :set_footer_template,
                only: [
      Severity: Minor
      Found in app/mailers/request_mailer.rb - About 2 hrs to fix

        Method alert_comment_on_request has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.alert_comment_on_request
    # We only check comments made in the last month - this means if the
    # cron jobs broke for more than a month events would be lost, but no
    # matter. I suspect the performance gain will be needed (with an index on updated_at)
        Severity: Major
        Found in app/mailers/request_mailer.rb - About 2 hrs to fix

          Method alert_not_clarified_request has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.alert_not_clarified_request
    info_requests = InfoRequest.
                      where("awaiting_description = ?
                             AND described_state = 'waiting_clarification'
                             AND info_requests.updated_at < ?
          Severity: Minor
          Found in app/mailers/request_mailer.rb - About 1 hr to fix

            Method alert_new_response_reminders_internal has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def self.alert_new_response_reminders_internal(days_since, type_code)
    info_requests = InfoRequest.
      where_old_unclassified(days_since).
        where(use_notifications: false).
          order(:id).
            Severity: Minor
            Found in app/mailers/request_mailer.rb - About 1 hr to fix

              Method alert_not_clarified_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.alert_not_clarified_request
    info_requests = InfoRequest.
                      where("awaiting_description = ?
                             AND described_state = 'waiting_clarification'
                             AND info_requests.updated_at < ?
              Severity: Minor
              Found in app/mailers/request_mailer.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method fake_response has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def fake_response(info_request, from_user, message_body, attachment_name, attachment_content)
              Severity: Minor
              Found in app/mailers/request_mailer.rb - About 35 mins to fix

                There are no issues that match your filters.

                Category
                Status