mysociety/alaveteli

View on GitHub
app/mailers/track_mailer.rb

Summary

Maintainability
C
1 day
Test Coverage

Method alert_tracks has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

  def self.alert_tracks
    done_something = false
    now = Time.zone.now
    one_week_ago = now - 7.days
    User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
Severity: Minor
Found in app/mailers/track_mailer.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method alert_tracks has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.alert_tracks
    done_something = false
    now = Time.zone.now
    one_week_ago = now - 7.days
    User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
Severity: Major
Found in app/mailers/track_mailer.rb - About 2 hrs to fix

    Method alert_tracks_loop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.alert_tracks_loop
        # Run alert_tracks in an endless loop, sleeping when there is nothing to do
        while true
          sleep_seconds = 1
          while !alert_tracks
    Severity: Minor
    Found in app/mailers/track_mailer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status