mysociety/alaveteli

View on GitHub
app/models/ability.rb

Summary

Maintainability
C
1 day
Test Coverage

Method initialize has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(user)
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.is_admin?
Severity: Minor
Found in app/models/ability.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(user)
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.is_admin?
Severity: Major
Found in app/models/ability.rb - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if feature_enabled? :alaveteli_pro
          # Accessing alaveteli professional
          if user && (user.is_pro_admin? || user.is_pro?)
            can :access, :alaveteli_pro
          end
    Severity: Critical
    Found in app/models/ability.rb - About 1 hr to fix

      Method can_view_with_prominence? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.can_view_with_prominence?(prominence, info_request, user)
          if info_request.embargo
            case prominence
            when 'hidden'
              User.view_hidden_and_embargoed?(user)
      Severity: Minor
      Found in app/models/ability.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status