Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/models/foi_attachment.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class FoiAttachment has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class FoiAttachment < ApplicationRecord
  include Rails.application.routes.url_helpers
  include LinkToHelper
  include MessageProminence
Severity: Minor
Found in app/models/foi_attachment.rb - About 2 hrs to fix

    Method body has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def body
    return @cached_body if @cached_body

    begin
      return file.download if masked?
    Severity: Minor
    Found in app/models/foi_attachment.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unmasked_body has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def unmasked_body
    MailHandler.attachment_body_for_hexdigest(
      raw_email.mail,
      hexdigest: hexdigest
    )
    Severity: Minor
    Found in app/models/foi_attachment.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ensure_filename! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def ensure_filename!
    if filename.blank?
      calc_ext = AlaveteliFileTypes.mimetype_to_extension(content_type)
      calc_ext = "bin" unless calc_ext
      if !within_rfc822_subject.nil?
    Severity: Minor
    Found in app/models/foi_attachment.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status