Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/models/profile_photo.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method convert_image has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def convert_image
    return if data.nil?
    return if image.nil?

    # convert to PNG if it isn't, and to right size
Severity: Minor
Found in app/models/profile_photo.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method data_and_draft_checks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def data_and_draft_checks
    if data.nil?
      errors.add(:data, _("Please choose a file containing your photo."))
      return
    end
Severity: Minor
Found in app/models/profile_photo.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status