Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/models/user.rb

Summary

Maintainability
D
2 days
Test Coverage

Class User has 72 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ApplicationRecord
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authentication
  include User::LoginToken
Severity: Major
Found in app/models/user.rb - About 1 day to fix

    File user.rb has 511 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class User < ApplicationRecord
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authentication
  include User::LoginToken
    Severity: Major
    Found in app/models/user.rb - About 1 day to fix

      Method authenticate_from_form has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.authenticate_from_form(params, specific_user_login = false)
    params[:email].strip!

    if specific_user_login
      auth_fail_message = _("Either the email or password was not recognised, please try again.")
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status