mysociety/alaveteli

View on GitHub

Comparing develop to 4221-mail-poller-timeouts

Last commit 1182408c 11 days ago
Compare on GitHub

Method start has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
New

  def start(&block)
    # Start a POP3 session and ensure that it will be closed in any case.
    unless block_given?
      raise ArgumentError.new("AlaveteliMailPoller#start takes a block")
    end
Severity: Minor
Found in lib/alaveteli_mail_poller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status

No ratings changes.