mysociety/alaveteli

View on GitHub
db/migrate/20140716131107_create_category_translation_tables.rb

Summary

Maintainability
D
2 days
Test Coverage

Method up has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  def up
    default_locale = AlaveteliLocalization.default_locale

    fields = {:title => :text,
              :description => :text}
Severity: Minor
Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method up has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def up
    default_locale = AlaveteliLocalization.default_locale

    fields = {:title => :text,
              :description => :text}
Severity: Major
Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 2 hrs to fix

    Method down has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def down
        # reinstate the columns
        add_column :public_body_categories, :locale, :string
        add_column :public_body_headings, :locale, :string
        add_column :public_body_headings, :name, :string
    Severity: Major
    Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 2 hrs to fix

      Method down has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def down
          # reinstate the columns
          add_column :public_body_categories, :locale, :string
          add_column :public_body_headings, :locale, :string
          add_column :public_body_headings, :name, :string
      Severity: Minor
      Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PublicBodyHeading.where('locale != ?', default_locale).each do |heading|
            default_heading = PublicBodyHeading.find_by_name_and_locale(heading.name, default_locale)
            AlaveteliLocalization.with_locale(heading.locale) do
              heading.translated_attributes.each do |a, default|
                value = heading.read_attribute(a)
      db/migrate/20140716131107_create_category_translation_tables.rb on lines 28..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PublicBodyCategory.where('locale != ?', default_locale).each do |category|
            default_category = PublicBodyCategory.find_by_category_tag_and_locale(category.category_tag, default_locale)
            AlaveteliLocalization.with_locale(category.locale) do
              category.translated_attributes.each do |a, default|
                value = category.read_attribute(a)
      db/migrate/20140716131107_create_category_translation_tables.rb on lines 66..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PublicBodyCategory.where(:locale => default_locale).each do |category|
            category.translated_attributes.each do |a, default|
              value = category.read_attribute(a)
              unless value.nil?
                category.send(:"#{a}=", value)
      Severity: Minor
      Found in db/migrate/20140716131107_create_category_translation_tables.rb and 1 other location - About 25 mins to fix
      db/migrate/20140716131107_create_category_translation_tables.rb on lines 55..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PublicBodyHeading.where(:locale => default_locale).each do |heading|
            heading.translated_attributes.each do |a, default|
              value = heading.read_attribute(a)
              unless value.nil?
                heading.send(:"#{a}=", value)
      Severity: Minor
      Found in db/migrate/20140716131107_create_category_translation_tables.rb and 1 other location - About 25 mins to fix
      db/migrate/20140716131107_create_category_translation_tables.rb on lines 17..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status