mysociety/alaveteli

View on GitHub

Showing 280 of 436 total issues

Method initialize has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(user, project: nil, public_token: false)
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.is_admin?
Severity: Minor
Found in app/models/ability.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File user_controller.rb has 470 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'set'

class UserController < ApplicationController
  include UserSpamCheck

Severity: Minor
Found in app/controllers/user_controller.rb - About 7 hrs to fix

    Class OutgoingMessage has 50 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class OutgoingMessage < ApplicationRecord
      include MessageProminence
      include Rails.application.routes.url_helpers
      include LinkToHelper
      include Taggable
    Severity: Minor
    Found in app/models/outgoing_message.rb - About 7 hrs to fix

      Class InfoRequestEvent has 49 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class InfoRequestEvent < ApplicationRecord
        extend XapianQueries
      
        EVENT_TYPES = [
          'sent',
      Severity: Minor
      Found in app/models/info_request_event.rb - About 6 hrs to fix

        File info_request_event.rb has 445 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        class InfoRequestEvent < ApplicationRecord
          extend XapianQueries
        
          EVENT_TYPES = [
            'sent',
        Severity: Minor
        Found in app/models/info_request_event.rb - About 6 hrs to fix

          File outgoing_message.rb has 418 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          class OutgoingMessage < ApplicationRecord
            include MessageProminence
            include Rails.application.routes.url_helpers
            include LinkToHelper
            include Taggable
          Severity: Minor
          Found in app/models/outgoing_message.rb - About 6 hrs to fix

            Method xapian_index has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
            Open

                def xapian_index(terms = true, values = true, texts = true)
                  # if we have a conditional function for indexing, call it and destroy object if failed
                  if self.class.xapian_options.include?(:if)
                    if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                    unless if_value
            Severity: Minor
            Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File request_mailer.rb has 411 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            class RequestMailer < ApplicationMailer
              include AlaveteliFeatures::Helpers
            
              before_action :set_footer_template,
                            only: [
            Severity: Minor
            Found in app/mailers/request_mailer.rb - About 5 hrs to fix

              Method alert_tracks has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.alert_tracks
                  done_something = false
                  now = Time.zone.now
                  one_week_ago = now - 7.days
                  User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
              Severity: Minor
              Found in app/mailers/track_mailer.rb - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method new has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
              Open

                def new
                  # All new requests are of normal_sort
                  unless params[:outgoing_message].nil?
                    params[:outgoing_message][:what_doing] = 'normal_sort'
                  end
              Severity: Minor
              Found in app/controllers/request_controller.rb - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method import_csv_from_file has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
                  errors = []
                  notes = []
                  begin
                    ActiveRecord::Base.transaction do
              Severity: Minor
              Found in app/models/public_body.rb - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize_query has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
              Open

                  def initialize_query(options)
                    #raise options.to_yaml
              
                    self.runtime += Benchmark.realtime {
                      offset = options[:offset] || 0
              Severity: Minor
              Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File mail_backend.rb has 382 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'mail'
              require 'mapi/msg'
              require 'mapi/convert'
              require 'config_helper'
              require 'alaveteli_file_types'
              Severity: Minor
              Found in lib/mail_handler/backends/mail_backend.rb - About 5 hrs to fix

                File incoming_message.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'rexml/document'
                require 'zip'
                
                class IncomingMessage < ApplicationRecord
                  include MessageProminence
                Severity: Minor
                Found in app/models/incoming_message.rb - About 5 hrs to fix

                  Method search has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def search
                      # TODO: Why is this so complicated with arrays and stuff? Look at the route
                      # in config/routes.rb for comments.
                  
                      combined = params[:combined].split("/")
                  Severity: Minor
                  Found in app/controllers/general_controller.rb - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Class IncomingMessage has 37 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class IncomingMessage < ApplicationRecord
                    include MessageProminence
                    include CacheAttributesFromRawEmail
                    include Taggable
                  
                  
                  Severity: Minor
                  Found in app/models/incoming_message.rb - About 4 hrs to fix

                    Class ApplicationController has 36 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    class ApplicationController < ActionController::Base
                      class PermissionDenied < StandardError
                      end
                    
                      class RouteNotFound < StandardError
                    Severity: Minor
                    Found in app/controllers/application_controller.rb - About 4 hrs to fix

                      Method permanently_failed_addresses has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def self.permanently_failed_addresses(message)
                            if MailHandler.empty_return_path?(message)
                              # Some sort of auto-response
                      
                              # Check for Exim’s X-Failed-Recipients header
                      Severity: Minor
                      Found in lib/mail_handler/reply_handler.rb - About 4 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Class UserController has 34 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      class UserController < ApplicationController
                        include UserSpamCheck
                      
                        skip_before_action :html_response, only: [
                          :show, :wall, :get_draft_profile_photo, :get_profile_photo
                      Severity: Minor
                      Found in app/controllers/user_controller.rb - About 4 hrs to fix

                        Class InfoRequest has 33 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class InfoRequest
                          module State
                            module Transitions
                              # Returns a label for the given state, suitable for using in a form to
                              # update the status of a request.
                        Severity: Minor
                        Found in app/models/info_request/state/transitions.rb - About 4 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language