mysociety/alaveteli

View on GitHub

Showing 339 of 436 total issues

File info_request.rb has 1392 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'digest/sha1'
require 'fileutils'

class InfoRequest < ApplicationRecord
  OLD_AGE_IN_DAYS = 21.days
Severity: Major
Found in app/models/info_request.rb - About 3 days to fix

    Class InfoRequest has 151 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class InfoRequest < ApplicationRecord
      OLD_AGE_IN_DAYS = 21.days
    
      include Rails.application.routes.url_helpers
      include AlaveteliPro::RequestSummaries
    Severity: Major
    Found in app/models/info_request.rb - About 2 days to fix

      File acts_as_xapian.rb has 824 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'English'
      begin
        require 'xapian'
        $acts_as_xapian_bindings_available = true
      
      
      Severity: Major
      Found in lib/acts_as_xapian/acts_as_xapian.rb - About 1 day to fix

        File public_body.rb has 721 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'csv'
        require 'securerandom'
        require 'set'
        require 'confidence_intervals'
        
        
        Severity: Major
        Found in app/models/public_body.rb - About 1 day to fix

          File routes.rb has 702 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'sidekiq/web'
          
          include AlaveteliFeatures::Constraints
          
          # Allow easy extension from themes. Note these will have the highest priority.
          Severity: Major
          Found in config/routes.rb - About 1 day to fix

            Class User has 75 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class User < ApplicationRecord
              include AlaveteliFeatures::Helpers
              include AlaveteliPro::PhaseCounts
              include User::Authentication
              include User::LoginToken
            Severity: Major
            Found in app/models/user.rb - About 1 day to fix

              File request_controller.rb has 612 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'zip'
              
              class RequestController < ApplicationController
                skip_before_action :html_response, only: [:show, :select_authorities]
              
              
              Severity: Major
              Found in app/controllers/request_controller.rb - About 1 day to fix

                Method initialize has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
                Open

                  def initialize(user, project: nil, public_token: false)
                    # Define abilities for the passed in user here. For example:
                    #
                    #   user ||= User.new # guest user (not logged in)
                    #   if user.is_admin?
                Severity: Minor
                Found in app/models/ability.rb - About 1 day to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File user.rb has 528 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                class User < ApplicationRecord
                  include AlaveteliFeatures::Helpers
                  include AlaveteliPro::PhaseCounts
                  include User::Authentication
                  include User::LoginToken
                Severity: Major
                Found in app/models/user.rb - About 1 day to fix

                  Class PublicBody has 60 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class PublicBody < ApplicationRecord
                    include CalculatedHomePage
                    include Categorisable
                    include Taggable
                    include Notable
                  Severity: Major
                  Found in app/models/public_body.rb - About 1 day to fix

                    Method get_language_name has 191 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def self.get_language_name(locale)
                        language_names = {
                          'ab'    => 'аҧсуа',
                          'aa'    => 'Afaraf',
                          'af'    => 'Afrikaans',
                    Severity: Major
                    Found in lib/languages.rb - About 7 hrs to fix

                      File user_controller.rb has 470 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require 'set'
                      
                      class UserController < ApplicationController
                        include UserSpamCheck
                      
                      
                      Severity: Minor
                      Found in app/controllers/user_controller.rb - About 7 hrs to fix

                        Class OutgoingMessage has 50 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class OutgoingMessage < ApplicationRecord
                          include MessageProminence
                          include Rails.application.routes.url_helpers
                          include LinkToHelper
                          include Taggable
                        Severity: Minor
                        Found in app/models/outgoing_message.rb - About 7 hrs to fix

                          Class InfoRequestEvent has 49 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          class InfoRequestEvent < ApplicationRecord
                            extend XapianQueries
                          
                            EVENT_TYPES = [
                              'sent',
                          Severity: Minor
                          Found in app/models/info_request_event.rb - About 6 hrs to fix

                            File info_request_event.rb has 445 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            class InfoRequestEvent < ApplicationRecord
                              extend XapianQueries
                            
                              EVENT_TYPES = [
                                'sent',
                            Severity: Minor
                            Found in app/models/info_request_event.rb - About 6 hrs to fix

                              Function d3TimeSeries has 158 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              function d3TimeSeries(selector, data, title, metric_name) {
                              
                                // Add the title
                                var wrapper_element = document.querySelectorAll(selector)[0];
                              
                              
                              Severity: Major
                              Found in app/assets/javascripts/time_series.js - About 6 hrs to fix

                                File outgoing_message.rb has 418 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                class OutgoingMessage < ApplicationRecord
                                  include MessageProminence
                                  include Rails.application.routes.url_helpers
                                  include LinkToHelper
                                  include Taggable
                                Severity: Minor
                                Found in app/models/outgoing_message.rb - About 6 hrs to fix

                                  Method xapian_index has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      def xapian_index(terms = true, values = true, texts = true)
                                        # if we have a conditional function for indexing, call it and destroy object if failed
                                        if self.class.xapian_options.include?(:if)
                                          if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                                          unless if_value
                                  Severity: Minor
                                  Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Method initialize has 147 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                    def initialize(user, project: nil, public_token: false)
                                      # Define abilities for the passed in user here. For example:
                                      #
                                      #   user ||= User.new # guest user (not logged in)
                                      #   if user.is_admin?
                                  Severity: Major
                                  Found in app/models/ability.rb - About 5 hrs to fix

                                    File request_mailer.rb has 411 lines of code (exceeds 250 allowed). Consider refactoring.
                                    Open

                                    class RequestMailer < ApplicationMailer
                                      include AlaveteliFeatures::Helpers
                                    
                                      before_action :set_footer_template,
                                                    only: [
                                    Severity: Minor
                                    Found in app/mailers/request_mailer.rb - About 5 hrs to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language