Showing 341 of 431 total issues
File info_request.rb
has 1338 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'digest/sha1'
require 'fileutils'
class InfoRequest < ApplicationRecord
Guess = Struct.new(:info_request, :matched_value, :match_method).freeze
Class InfoRequest
has 141 methods (exceeds 20 allowed). Consider refactoring. Open
class InfoRequest < ApplicationRecord
Guess = Struct.new(:info_request, :matched_value, :match_method).freeze
OLD_AGE_IN_DAYS = 21.days
include AdminColumn
File acts_as_xapian.rb
has 796 lines of code (exceeds 250 allowed). Consider refactoring. Open
begin
require 'xapian'
$acts_as_xapian_bindings_available = true
rescue LoadError
STDERR.puts "acts_as_xapian: No Ruby bindings for Xapian installed"
File public_body.rb
has 693 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'csv'
require 'securerandom'
require 'set'
require 'confidence_intervals'
File request_controller.rb
has 631 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'zip'
class RequestController < ApplicationController
skip_before_action :html_response, only: [:show, :select_authorities]
File routes.rb
has 621 lines of code (exceeds 250 allowed). Consider refactoring. Open
include AlaveteliFeatures::Constraints
# Allow easy extension from themes. Note these will have the highest priority.
$alaveteli_route_extensions.each do |f|
load File.join('config', f)
Class User
has 69 methods (exceeds 20 allowed). Consider refactoring. Open
class User < ApplicationRecord
include AlaveteliFeatures::Helpers
include AlaveteliPro::PhaseCounts
include User::Authentication
include User::LoginToken
Method initialize
has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring. Open
def initialize(user, project: nil, public_token: false)
# Define abilities for the passed in user here. For example:
#
# user ||= User.new # guest user (not logged in)
# if user.is_admin?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method xapian_index
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
def xapian_index(terms = true, values = true, texts = true)
# if we have a conditional function for indexing, call it and destroy object if failed
if self.class.xapian_options.include?(:if)
if_value = xapian_value(self.class.xapian_options[:if], :boolean)
if not if_value
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method alert_tracks
has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring. Open
def self.alert_tracks
done_something = false
now = Time.zone.now
one_week_ago = now - 7.days
User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File user.rb
has 487 lines of code (exceeds 250 allowed). Consider refactoring. Open
class User < ApplicationRecord
include AlaveteliFeatures::Helpers
include AlaveteliPro::PhaseCounts
include User::Authentication
include User::LoginToken
Method get_language_name
has 191 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.get_language_name(locale)
language_names = {
'ab' => 'аҧсуа',
'aa' => 'Afaraf',
'af' => 'Afrikaans',
Class PublicBody
has 52 methods (exceeds 20 allowed). Consider refactoring. Open
class PublicBody < ApplicationRecord
include AdminColumn
include Taggable
class ImportCSVDryRun < StandardError; end
File user_controller.rb
has 462 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'set'
class UserController < ApplicationController
include UserSpamCheck
Class OutgoingMessage
has 47 methods (exceeds 20 allowed). Consider refactoring. Open
class OutgoingMessage < ApplicationRecord
include AdminColumn
include MessageProminence
include Rails.application.routes.url_helpers
include LinkToHelper
Class InfoRequestEvent
has 46 methods (exceeds 20 allowed). Consider refactoring. Open
class InfoRequestEvent < ApplicationRecord
include AdminColumn
extend XapianQueries
EVENT_TYPES = [
Function d3TimeSeries
has 158 lines of code (exceeds 25 allowed). Consider refactoring. Open
function d3TimeSeries(selector, data, title, metric_name) {
// Add the title
var wrapper_element = document.querySelectorAll(selector)[0];
File incoming_message.rb
has 414 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'rexml/document'
require 'zip'
class IncomingMessage < ApplicationRecord
include AdminColumn
Method import_csv_from_file
has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring. Open
def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
errors = []
notes = []
begin
ActiveRecord::Base.transaction do
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File info_request_event.rb
has 413 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'yaml_compatibility'
class InfoRequestEvent < ApplicationRecord
include AdminColumn
extend XapianQueries