Showing 340 of 436 total issues
Method search
has 92 lines of code (exceeds 25 allowed). Consider refactoring. Open
def search
# TODO: Why is this so complicated with arrays and stuff? Look at the route
# in config/routes.rb for comments.
combined = params[:combined].split("/")
Method params_for_jsonb
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
def params_for_jsonb(params)
params.inject({}) do |memo, (k, v)|
key = k.to_s
# look for keys ending in `_id` and attempt to map to a Ruby class
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method destroy_and_rebuild_index
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
#raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
prepare_environment
update_existing = !(terms == true && values == true && texts == true)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method alert_comment_on_request
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
def self.alert_comment_on_request
# We only check comments made in the last month - this means if the
# cron jobs broke for more than a month events would be lost, but no
# matter. I suspect the performance gain will be needed (with an index on updated_at)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method xapian_index
has 85 lines of code (exceeds 25 allowed). Consider refactoring. Open
def xapian_index(terms = true, values = true, texts = true)
# if we have a conditional function for indexing, call it and destroy object if failed
if self.class.xapian_options.include?(:if)
if_value = xapian_value(self.class.xapian_options[:if], :boolean)
unless if_value
Method get_attachment_text_one_file
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
def get_attachment_text_one_file(content_type, body, charset = 'utf-8')
# NOTE: re. charset: TMail always tries to convert email bodies
# to UTF8 by default, so normally it should already be that.
text = ''
# TODO: - tell all these command line tools to return utf-8
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class InfoRequestBatch
has 26 methods (exceeds 20 allowed). Consider refactoring. Open
class InfoRequestBatch < ApplicationRecord
include AlaveteliPro::RequestSummaries
include AlaveteliFeatures::Helpers
include InfoRequest::TitleValidation
Function setUpCorrespondenceCollapsing
has 75 lines of code (exceeds 25 allowed). Consider refactoring. Open
var setUpCorrespondenceCollapsing = function(){
$('.js-collapsable').each(function(){
var $collapsable = $(this);
var $triggers = $(this).find('.js-collapsable-trigger');
var $correspondenceHeader = $(this).find('.correspondence__header');
Method index
has 73 lines of code (exceeds 25 allowed). Consider refactoring. Open
def index
# Tasks to do
@requires_admin_requests = InfoRequest.
find_in_state('requires_admin').
not_embargoed
Method import_csv
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def import_csv
@notes = ""
@errors = ""
if request.post?
dry_run_only = params['commit'] != 'Upload'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method render_new_compose
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def render_new_compose
params[:info_request] = {} unless params[:info_request]
# Reconstruct the params
# first the public body (by URL name or id)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method alert_overdue_requests
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def self.alert_overdue_requests
info_requests = InfoRequest.where("described_state = 'waiting_response'
AND awaiting_description = ?
AND user_id is not null
AND use_notifications = ?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_status_from_params
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def get_status_from_params(params)
query = ""
if params[:latest_status]
statuses = []
if params[:latest_status].class == String
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_correspondence
has 72 lines of code (exceeds 25 allowed). Consider refactoring. Open
def add_correspondence
json = ActiveSupport::JSON.decode(params[:correspondence_json])
attachments = params[:attachments]
direction = json["direction"]
Class RequestFilter
has 25 methods (exceeds 20 allowed). Consider refactoring. Open
class RequestFilter
extend ActiveModel::Naming
include ActiveModel::Conversion
attr_accessor :filter, :order, :search
File wizard.js
has 283 lines of code (exceeds 250 allowed). Consider refactoring. Open
(function($) {
var RefusalWizard = function(target, options) {
this.$el = $(target);
var defaults = {
Method authenticate
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
def authenticate
if AlaveteliConfiguration.skip_admin_auth
session[:using_admin] = 1
nil
elsif session[:using_admin].nil? || session[:admin_name].nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if feature_enabled? :alaveteli_pro
# Accessing alaveteli professional
if user && (user.is_pro_admin? || user.is_pro?)
can :access, :alaveteli_pro
end
Class Storage
has 24 methods (exceeds 20 allowed). Consider refactoring. Open
class Storage
def initialize(klass, association, setter: :data=, getter: :data,
condition: nil)
@klass = klass
@association = association
Method alert_overdue_requests
has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.alert_overdue_requests
info_requests = InfoRequest.where("described_state = 'waiting_response'
AND awaiting_description = ?
AND user_id is not null
AND use_notifications = ?