File application_controller.rb has 336 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class ApplicationController < ActionController::Base
  class PermissionDenied < StandardError
  end

  class RouteNotFound < StandardError

Class RequestController has 32 methods (exceeds 20 allowed). Consider refactoring.

Open

class RequestController < ApplicationController
  skip_before_action :html_response, only: [:show, :select_authorities]

  before_action :check_read_only, only: [:new, :upload_response]
  before_action :set_render_recaptcha, only: [ :new ]

Method signup has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.

Open

  def signup
    # Make the user and try to save it
    @user_signup = User.new(user_params(:user_signup))
    error = false
    if @request_from_foreign_country && !verify_recaptcha

• Read up
  Read up

Method clean_po has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.

Open

    def clean_po(input)
      lines = input.split("\n")

      lines.each_with_index do |line, index|
        match = /^msgid "(.*)"/.match(line)

• Read up
  Read up

Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.

Open

    def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
      fixture_set_names = Array(fixture_set_names).map(&:to_s)
      class_names = ClassCache.new class_names, config

      # FIXME: Apparently JK uses this.

• Read up
  Read up

Method params_for_jsonb has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.

Open

  def params_for_jsonb(params)
    params.inject({}) do |memo, (k, v)|
      key = k.to_s

      # look for keys ending in `_id` and attempt to map to a Ruby class

• Read up
  Read up

Method alert_comment_on_request has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.

Open

  def self.alert_comment_on_request
    # We only check comments made in the last month - this means if the
    # cron jobs broke for more than a month events would be lost, but no
    # matter. I suspect the performance gain will be needed (with an index on updated_at)

• Read up
  Read up

Method destroy_and_rebuild_index has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.

Open

  def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
    #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
    prepare_environment

    update_existing = !(terms == true && values == true && texts == true)

• Read up
  Read up

Method get_attachment_text_one_file has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.

Open

  def get_attachment_text_one_file(content_type, body, charset = 'utf-8')
    # NOTE: re. charset: TMail always tries to convert email bodies
    # to UTF8 by default, so normally it should already be that.
    text = ''
    # TODO: - tell all these command line tools to return utf-8

• Read up
  Read up

Class InfoRequestBatch has 26 methods (exceeds 20 allowed). Consider refactoring.

Open

class InfoRequestBatch < ApplicationRecord
  include AlaveteliPro::RequestSummaries
  include AlaveteliFeatures::Helpers
  include InfoRequest::TitleValidation

Method render_new_compose has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

  def render_new_compose
    params[:info_request] = {} unless params[:info_request]

    # Reconstruct the params
    # first the public body (by URL name or id)

• Read up
  Read up

Method alert_overdue_requests has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

  def self.alert_overdue_requests
    info_requests = InfoRequest.where("described_state = 'waiting_response'
                AND awaiting_description = ?
                AND user_id is not null
                AND use_notifications = ?

• Read up
  Read up

Method import_csv has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

  def import_csv
    @notes = ""
    @errors = ""
    if request.post?
      dry_run_only = params['commit'] != 'Upload'

• Read up
  Read up

Method get_status_from_params has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

  def get_status_from_params(params)
    query = ""
    if params[:latest_status]
      statuses = []
      if params[:latest_status].class == String

• Read up
  Read up

Class RequestFilter has 25 methods (exceeds 20 allowed). Consider refactoring.

Open

  class RequestFilter
    extend ActiveModel::Naming
    include ActiveModel::Conversion

    attr_accessor :filter, :order, :search

File wizard.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.

Open

(function($) {
  var RefusalWizard = function(target, options) {
    this.$el = $(target);

    var defaults = {

Method authenticate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.

Open

  def authenticate
    if AlaveteliConfiguration.skip_admin_auth
      session[:using_admin] = 1
      nil
    elsif session[:using_admin].nil? || session[:admin_name].nil?

• Read up
  Read up

Class Storage has 24 methods (exceeds 20 allowed). Consider refactoring.

Open

class Storage
  def initialize(klass, association, setter: :data=, getter: :data,
                 condition: nil)
    @klass = klass
    @association = association

Method upload_response has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.

Open

  def upload_response
    AlaveteliLocalization.with_locale(locale) do
      @info_request = InfoRequest.not_embargoed.find_by_url_title!(params[:url_title])

      @reason_params = {

• Read up
  Read up

Method start has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.

Open

  def self.start(opt={})
    opt = DEFAULTS.dup.merge(opt)

    Thread.new do
      prev = Hash.new(0)

• Read up
  Read up