mysociety/alaveteli

View on GitHub

Showing 366 of 1,299 total issues

Method table_rows has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

    def table_rows
      now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
      now = now.to_s(:db)

      # allow a standard key to be used for doing defaults in YAML
Severity: Minor
Found in lib/fixture_set_table_rows_patch.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method alert_tracks has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

  def self.alert_tracks
    done_something = false
    now = Time.zone.now
    one_week_ago = now - 7.days
    User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
Severity: Minor
Found in app/mailers/track_mailer.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File user.rb has 484 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class User < ActiveRecord::Base
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authenication

Severity: Minor
Found in app/models/user.rb - About 7 hrs to fix

    File admin_public_body_headings_controller_spec.rb has 467 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'spec_helper'
    
    describe AdminPublicBodyHeadingsController do
    
      describe 'GET new' do
    Severity: Minor
    Found in spec/controllers/admin_public_body_headings_controller_spec.rb - About 7 hrs to fix

      File user_controller.rb has 466 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'set'
      
      class UserController < ApplicationController
        layout :select_layout
        # NOTE: Rails 4 syntax: change before_filter to before_action
      Severity: Minor
      Found in app/controllers/user_controller.rb - About 7 hrs to fix

        Method xapian_index has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
        Open

            def xapian_index(terms = true, values = true, texts = true)
              # if we have a conditional function for indexing, call it and destroy object if failed
              if self.class.xapian_options.include?(:if)
                if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                if not if_value
        Severity: Minor
        Found in lib/acts_as_xapian/acts_as_xapian.rb - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File mail_server_log_spec.rb has 451 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
        
        describe MailServerLog do
          describe ".load_file" do
            before :each do
        Severity: Minor
        Found in spec/models/mail_server_log_spec.rb - About 6 hrs to fix

          Method initialize has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
          Open

            def initialize(user)
              # Define abilities for the passed in user here. For example:
              #
              #   user ||= User.new # guest user (not logged in)
              #   if user.is_admin?
          Severity: Minor
          Found in app/models/ability.rb - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File info_request_helper_spec.rb has 443 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
          
          describe InfoRequestHelper do
          
            include InfoRequestHelper
          Severity: Minor
          Found in spec/helpers/info_request_helper_spec.rb - About 6 hrs to fix

            Class PublicBody has 47 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class PublicBody < ActiveRecord::Base
              include AdminColumn
            
              class ImportCSVDryRun < StandardError ; end
            
            
            Severity: Minor
            Found in app/models/public_body.rb - About 6 hrs to fix

              Class InfoRequestEvent has 46 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class InfoRequestEvent < ActiveRecord::Base
                include AdminColumn
                extend XapianQueries
              
                EVENT_TYPES = [
              Severity: Minor
              Found in app/models/info_request_event.rb - About 6 hrs to fix

                File incoming_message.rb has 427 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'rexml/document'
                require 'zip'
                require 'iconv' unless String.method_defined?(:encode)
                
                class IncomingMessage < ActiveRecord::Base
                Severity: Minor
                Found in app/models/incoming_message.rb - About 6 hrs to fix

                  File api_controller_spec.rb has 425 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                  
                  describe ApiController, "when using the API" do
                  
                    describe 'checking API keys' do
                  Severity: Minor
                  Found in spec/controllers/api_controller_spec.rb - About 6 hrs to fix

                    Class IncomingMessage has 45 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    class IncomingMessage < ActiveRecord::Base
                      include AdminColumn
                      include MessageProminence
                    
                      MAX_ATTACHMENT_TEXT_CLIPPED = 1000000 # 1Mb ish
                    Severity: Minor
                    Found in app/models/incoming_message.rb - About 6 hrs to fix

                      Method import_csv_from_file has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
                          errors = []
                          notes = []
                          begin
                            ActiveRecord::Base.transaction do
                      Severity: Minor
                      Found in app/models/public_body.rb - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File user_spam_scorer_spec.rb has 410 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                      
                      describe UserSpamScorer do
                      
                        after(:each) { described_class.reset }
                      Severity: Minor
                      Found in spec/lib/user_spam_scorer_spec.rb - About 5 hrs to fix

                        Class OutgoingMessage has 43 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class OutgoingMessage < ActiveRecord::Base
                          include AdminColumn
                          include MessageProminence
                          include Rails.application.routes.url_helpers
                          include LinkToHelper
                        Severity: Minor
                        Found in app/models/outgoing_message.rb - About 5 hrs to fix

                          Class RequestController has 43 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          class RequestController < ApplicationController
                            before_filter :check_read_only, :only => [ :new, :describe_state, :upload_response ]
                            before_filter :check_batch_requests_and_user_allowed, :only => [ :select_authorities, :new_batch ]
                            before_filter :set_render_recaptcha, :only => [ :new ]
                            before_filter :redirect_numeric_id_to_url_title, :only => [:show]
                          Severity: Minor
                          Found in app/controllers/request_controller.rb - About 5 hrs to fix

                            File info_request_event.rb has 407 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            class InfoRequestEvent < ActiveRecord::Base
                              include AdminColumn
                              extend XapianQueries
                            
                              EVENT_TYPES = [
                            Severity: Minor
                            Found in app/models/info_request_event.rb - About 5 hrs to fix

                              File request_mailer.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              class RequestMailer < ApplicationMailer
                                include AlaveteliFeatures::Helpers
                              
                                # Used when an FOI officer uploads a response from their web browser - this is
                                # the "fake" email used to store in the same format in the database as if they
                              Severity: Minor
                              Found in app/mailers/request_mailer.rb - About 5 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language