mysociety/alaveteli

View on GitHub

Showing 465 of 631 total issues

Function init has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function init(plot) {
        // Taken from flot-axislabels.
        // This is kind of a hack. There are no hooks in Flot between
        // the creation and measuring of the ticks (setTicks, measureTickLabels
        // in setupGrid() ) and the drawing of the ticks and plot box
Severity: Major
Found in app/assets/javascripts/jquery.flot.tickrotor.js - About 4 hrs to fix

    Method world_foi_websites has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.world_foi_websites
        world_foi_websites = [
          { :name => "WhatDoTheyKnow",
            :country_name => "United Kingdom",
            :country_iso_code => "GB",
    Severity: Major
    Found in lib/world_foi_websites.rb - About 4 hrs to fix

      File jquery.flot.axislabels.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
      Axis Labels Plugin for flot.
      http://github.com/markrcote/flot-axislabels
      
      Original code is Copyright (c) 2010 Xuan Luo.
      Severity: Minor
      Found in app/assets/javascripts/jquery.flot.axislabels.js - About 4 hrs to fix

        Class InfoRequest has 33 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class InfoRequest
          module State
            module Transitions
              # Returns a label for the given state, suitable for using in a form to
              # update the status of a request.
        Severity: Minor
        Found in app/models/info_request/state/transitions.rb - About 4 hrs to fix

          Method search has 100 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def search
              # TODO: Why is this so complicated with arrays and stuff? Look at the route
              # in config/routes.rb for comments.
          
              # 404 if the request is a format we don't support (e.g:.json)
          Severity: Major
          Found in app/controllers/general_controller.rb - About 4 hrs to fix

            Function refreshOptions has 99 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    refreshOptions: function(triggerDropdown) {
                        var i, j, k, n, groups, groups_order, option, option_html, optgroup, optgroups, html, html_children, has_create_option;
                        var $active, $active_before, $create;
                
                        if (typeof triggerDropdown === 'undefined') {
            Severity: Major
            Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 3 hrs to fix

              Method clean_po has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  def clean_po(input)
                    lines = input.split("\n")
              
                    lines.each_with_index do |line, index|
                      match = /^msgid "(.*)"/.match(line)
              Severity: Minor
              Found in lib/alaveteli_gettext/fuzzy_cleaner.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function plotLineArea has 96 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          function plotLineArea(datapoints, axisx, axisy) {
                              var points = datapoints.points,
                                  ps = datapoints.pointsize,
                                  bottom = Math.min(Math.max(0, axisy.min), axisy.max),
                                  i = 0, top, areaOpen = false,
              Severity: Major
              Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                Class UserController has 31 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class UserController < ApplicationController
                  include UserSpamCheck
                
                  layout :select_layout
                  before_action :normalize_url_name, :only => :show
                Severity: Minor
                Found in app/controllers/user_controller.rb - About 3 hrs to fix

                  Function setupTickGeneration has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          function setupTickGeneration(axis) {
                              var opts = axis.options;
                  
                              // estimate number of ticks
                              var noTicks;
                  Severity: Major
                  Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                    Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
                          fixture_set_names = Array(fixture_set_names).map(&:to_s)
                          class_names = ClassCache.new class_names, config
                    
                          # FIXME: Apparently JK uses this.
                    Severity: Minor
                    Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method alert_comment_on_request has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def self.alert_comment_on_request
                    
                        # We only check comments made in the last month - this means if the
                        # cron jobs broke for more than a month events would be lost, but no
                        # matter. I suspect the performance gain will be needed (with an index on updated_at)
                    Severity: Minor
                    Found in app/mailers/request_mailer.rb - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function parseOptions has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            function parseOptions(opts) {
                    
                                $.extend(true, options, opts);
                    
                                // $.extend merges arrays, rather than replacing them.  When less
                    Severity: Major
                    Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                      Method new has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def new
                          # All new requests are of normal_sort
                          if !params[:outgoing_message].nil?
                            params[:outgoing_message][:what_doing] = 'normal_sort'
                          end
                      Severity: Major
                      Found in app/controllers/request_controller.rb - About 3 hrs to fix

                        Method describe_state has 87 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          def describe_state
                            info_request = InfoRequest.not_embargoed.find(params[:id].to_i)
                            set_last_request(info_request)
                        
                            # If this is an external request, go to the request page - we don't allow
                        Severity: Major
                        Found in app/controllers/request_controller.rb - About 3 hrs to fix

                          Method initialize has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            def initialize(user)
                              # Define abilities for the passed in user here. For example:
                              #
                              #   user ||= User.new # guest user (not logged in)
                              #   if user.is_admin?
                          Severity: Major
                          Found in app/models/ability.rb - About 3 hrs to fix

                            Method xapian_index has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                def xapian_index(terms = true, values = true, texts = true)
                                  # if we have a conditional function for indexing, call it and destroy object if failed
                                  if self.class.xapian_options.include?(:if)
                                    if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                                    if not if_value
                            Severity: Major
                            Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

                              File mail_backend.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              require 'mail'
                              require 'mapi/msg'
                              require 'mapi/convert'
                              
                              module Mail
                              Severity: Minor
                              Found in lib/mail_handler/backends/mail_backend.rb - About 3 hrs to fix

                                Method render_new_compose has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  def render_new_compose(batch)
                                    params[:info_request] = { } if !params[:info_request]
                                
                                    # Reconstruct the params
                                    unless batch
                                Severity: Minor
                                Found in app/controllers/request_controller.rb - About 3 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method destroy_and_rebuild_index has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
                                    #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
                                    prepare_environment
                                
                                    update_existing = !(terms == true && values == true && texts == true)
                                Severity: Minor
                                Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language