Sign upLogin

mysociety/alaveteli

View on GitHub
Star

Showing 420 of 433 total issues

Method initialize has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(user, project: nil, public_token: false)
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.is_admin?
Severity: Major
Found in app/models/ability.rb - About 5 hrs to fix

    File request_mailer.rb has 411 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class RequestMailer < ApplicationMailer
  include AlaveteliFeatures::Helpers

  before_action :set_footer_template,
                only: [
    Severity: Minor
    Found in app/mailers/request_mailer.rb - About 5 hrs to fix

      Method alert_tracks has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.alert_tracks
    done_something = false
    now = Time.zone.now
    one_week_ago = now - 7.days
    User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
      Severity: Minor
      Found in app/mailers/track_mailer.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method new has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
      Open

        def new
    # All new requests are of normal_sort
    unless params[:outgoing_message].nil?
      params[:outgoing_message][:what_doing] = 'normal_sort'
    end
      Severity: Minor
      Found in app/controllers/request_controller.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_csv_from_file has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
    errors = []
    notes = []
    begin
      ActiveRecord::Base.transaction do
      Severity: Minor
      Found in app/models/public_body.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        BatchAuthoritySearch.bindXHR = function bindXHR() {
    BatchAuthoritySearch.currentXHR.done(function(data) {
      $el.trigger(Events.loadingSuccess, {html: data});
    });
    BatchAuthoritySearch.currentXHR.fail(function(xhr, textStatus) {
      Severity: Major
      Found in app/assets/javascripts/alaveteli_pro/batch_authority_search/initialise.js and 1 other location - About 5 hrs to fix
      app/assets/javascripts/alaveteli_pro/draft_batch_summary/initialise.js on lines 33..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        DraftBatchSummary.bindXHR = function bindXHR() {
    DraftBatchSummary.currentXHR.done(function(data) {
      $el.trigger(Events.loadingSuccess, {html: data});
    });
    DraftBatchSummary.currentXHR.fail(function(xhr, textStatus) {
      Severity: Major
      Found in app/assets/javascripts/alaveteli_pro/draft_batch_summary/initialise.js and 1 other location - About 5 hrs to fix
      app/assets/javascripts/alaveteli_pro/batch_authority_search/initialise.js on lines 31..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method initialize_query has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize_query(options)
      #raise options.to_yaml

      self.runtime += Benchmark.realtime {
        offset = options[:offset] || 0
      Severity: Minor
      Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File mail_backend.rb has 382 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'mail'
require 'mapi/msg'
require 'mapi/convert'
require 'config_helper'
require 'alaveteli_file_types'
      Severity: Minor
      Found in lib/mail_handler/backends/mail_backend.rb - About 5 hrs to fix

        File incoming_message.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'rexml/document'
require 'zip'

class IncomingMessage < ApplicationRecord
  include MessageProminence
        Severity: Minor
        Found in app/models/incoming_message.rb - About 5 hrs to fix

          Method search has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
          Open

            def search
    # TODO: Why is this so complicated with arrays and stuff? Look at the route
    # in config/routes.rb for comments.

    combined = params[:combined].split("/")
          Severity: Minor
          Found in app/controllers/general_controller.rb - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Class IncomingMessage has 37 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class IncomingMessage < ApplicationRecord
  include MessageProminence
  include CacheAttributesFromRawEmail
  include Taggable
          Severity: Minor
          Found in app/models/incoming_message.rb - About 4 hrs to fix

            Class ApplicationController has 37 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class ApplicationController < ActionController::Base
  class PermissionDenied < StandardError
  end

  class RouteNotFound < StandardError
            Severity: Minor
            Found in app/controllers/application_controller.rb - About 4 hrs to fix

              Method world_foi_websites has 115 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def self.world_foi_websites
    world_foi_websites = [
      { name: "WhatDoTheyKnow",
        country_name: "United Kingdom",
        country_iso_code: "GB",
              Severity: Major
              Found in lib/world_foi_websites.rb - About 4 hrs to fix

                Method permanently_failed_addresses has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                Open

                    def self.permanently_failed_addresses(message)
      if MailHandler.empty_return_path?(message)
        # Some sort of auto-response

        # Check for Exim’s X-Failed-Recipients header
                Severity: Minor
                Found in lib/mail_handler/reply_handler.rb - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Class UserController has 34 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class UserController < ApplicationController
  include UserSpamCheck

  skip_before_action :html_response, only: [
    :show, :wall, :get_draft_profile_photo, :get_profile_photo
                Severity: Minor
                Found in app/controllers/user_controller.rb - About 4 hrs to fix

                  Class InfoRequest has 33 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class InfoRequest
  module State
    module Transitions
      # Returns a label for the given state, suitable for using in a form to
      # update the status of a request.
                  Severity: Minor
                  Found in app/models/info_request/state/transitions.rb - About 4 hrs to fix

                    Class RequestController has 33 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    class RequestController < ApplicationController
  skip_before_action :html_response, only: [:show, :select_authorities]

  before_action :check_read_only, only: [:new, :upload_response]
  before_action :set_render_recaptcha, only: [ :new ]
                    Severity: Minor
                    Found in app/controllers/request_controller.rb - About 4 hrs to fix

                      Method new has 104 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def new
    # All new requests are of normal_sort
    unless params[:outgoing_message].nil?
      params[:outgoing_message][:what_doing] = 'normal_sort'
    end
                      Severity: Major
                      Found in app/controllers/request_controller.rb - About 4 hrs to fix

                        File application_controller.rb has 336 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        class ApplicationController < ActionController::Base
  class PermissionDenied < StandardError
  end

  class RouteNotFound < StandardError
                        Severity: Minor
                        Found in app/controllers/application_controller.rb - About 4 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language