mysociety/alaveteli

View on GitHub

Showing 422 of 435 total issues

Method signup has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def signup
    # Make the user and try to save it
    @user_signup = User.new(user_params(:user_signup))
    error = false
    if @request_from_foreign_country && !verify_recaptcha
Severity: Minor
Found in app/controllers/user_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method clean_po has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def clean_po(input)
      lines = input.split("\n")

      lines.each_with_index do |line, index|
        match = /^msgid "(.*)"/.match(line)
Severity: Minor
Found in lib/alaveteli_gettext/fuzzy_cleaner.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
      fixture_set_names = Array(fixture_set_names).map(&:to_s)
      class_names = ClassCache.new class_names, config

      # FIXME: Apparently JK uses this.
Severity: Minor
Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stripeForm has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function stripeForm(form, options) {
  var that = Object.assign({
    stripe: Stripe(AlaveteliPro.stripe_publishable_key),
    form: form,
    submit: document.getElementById('js-stripe-submit'),
Severity: Major
Found in app/assets/javascripts/alaveteli_pro/stripe.js - About 3 hrs to fix

    Method search has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def search
        # TODO: Why is this so complicated with arrays and stuff? Look at the route
        # in config/routes.rb for comments.
    
        combined = params[:combined].split("/")
    Severity: Major
    Found in app/controllers/general_controller.rb - About 3 hrs to fix

      Method params_for_jsonb has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

        def params_for_jsonb(params)
          params.inject({}) do |memo, (k, v)|
            key = k.to_s
      
            # look for keys ending in `_id` and attempt to map to a Ruby class
      Severity: Minor
      Found in app/models/info_request_event.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method destroy_and_rebuild_index has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
          #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
          prepare_environment
      
          update_existing = !(terms == true && values == true && texts == true)
      Severity: Minor
      Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method alert_comment_on_request has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.alert_comment_on_request
          # We only check comments made in the last month - this means if the
          # cron jobs broke for more than a month events would be lost, but no
          # matter. I suspect the performance gain will be needed (with an index on updated_at)
      
      
      Severity: Minor
      Found in app/mailers/request_mailer.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method xapian_index has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def xapian_index(terms = true, values = true, texts = true)
            # if we have a conditional function for indexing, call it and destroy object if failed
            if self.class.xapian_options.include?(:if)
              if_value = xapian_value(self.class.xapian_options[:if], :boolean)
              unless if_value
      Severity: Major
      Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        RSpec.describe AlaveteliFeatures::Helpers do
          let(:instance) { Class.new { include AlaveteliFeatures::Helpers }.new }
          let(:test_backend) { Flipper.new(Flipper::Adapters::Memory.new) }
        
          around do |example|
        Severity: Major
        Found in gems/alaveteli_features/spec/helpers/enable_actor_spec.rb and 1 other location - About 3 hrs to fix
        gems/alaveteli_features/spec/helpers/disable_actor_spec.rb on lines 6..39

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        RSpec.describe AlaveteliFeatures::Helpers do
          let(:instance) { Class.new { include AlaveteliFeatures::Helpers }.new }
          let(:test_backend) { Flipper.new(Flipper::Adapters::Memory.new) }
        
          around do |example|
        Severity: Major
        Found in gems/alaveteli_features/spec/helpers/disable_actor_spec.rb and 1 other location - About 3 hrs to fix
        gems/alaveteli_features/spec/helpers/enable_actor_spec.rb on lines 6..37

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method get_attachment_text_one_file has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_attachment_text_one_file(content_type, body, charset = 'utf-8')
            # NOTE: re. charset: TMail always tries to convert email bodies
            # to UTF8 by default, so normally it should already be that.
            text = ''
            # TODO: - tell all these command line tools to return utf-8
        Severity: Minor
        Found in lib/mail_handler.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setUpCorrespondenceCollapsing has 75 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var setUpCorrespondenceCollapsing = function(){
          $('.js-collapsable').each(function(){
            var $collapsable = $(this);
            var $triggers = $(this).find('.js-collapsable-trigger');
            var $correspondenceHeader = $(this).find('.correspondence__header');
        Severity: Major
        Found in app/assets/javascripts/correspondence-collapse.js - About 3 hrs to fix

          Class InfoRequestBatch has 26 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class InfoRequestBatch < ApplicationRecord
            include AlaveteliPro::RequestSummaries
            include AlaveteliFeatures::Helpers
            include InfoRequest::TitleValidation
          
          
          Severity: Minor
          Found in app/models/info_request_batch.rb - About 3 hrs to fix

            Method index has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def index
                # Tasks to do
                @requires_admin_requests = InfoRequest.
                  find_in_state('requires_admin').
                    not_embargoed
            Severity: Major
            Found in app/controllers/admin_general_controller.rb - About 2 hrs to fix

              Method import_csv has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                def import_csv
                  @notes = ""
                  @errors = ""
                  if request.post?
                    dry_run_only = params['commit'] != 'Upload'
              Severity: Minor
              Found in app/controllers/admin_public_body_controller.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method render_new_compose has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                def render_new_compose
                  params[:info_request] = {} unless params[:info_request]
              
                  # Reconstruct the params
                  # first the public body (by URL name or id)
              Severity: Minor
              Found in app/controllers/request_controller.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method alert_overdue_requests has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.alert_overdue_requests
                  info_requests = InfoRequest.where("described_state = 'waiting_response'
                              AND awaiting_description = ?
                              AND user_id is not null
                              AND use_notifications = ?
              Severity: Minor
              Found in app/mailers/request_mailer.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_status_from_params has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                def get_status_from_params(params)
                  query = ""
                  if params[:latest_status]
                    statuses = []
                    if params[:latest_status].class == String
              Severity: Minor
              Found in lib/xapian_queries.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add_correspondence has 72 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def add_correspondence
                  json = ActiveSupport::JSON.decode(params[:correspondence_json])
                  attachments = params[:attachments]
              
                  direction = json["direction"]
              Severity: Major
              Found in app/controllers/api_controller.rb - About 2 hrs to fix
                Severity
                Category
                Status
                Source
                Language