mysociety/alaveteli

File info_request.rb has 1392 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'digest/sha1'
require 'fileutils'

class InfoRequest < ApplicationRecord
  OLD_AGE_IN_DAYS = 21.days

Class InfoRequest has 151 methods (exceeds 20 allowed). Consider refactoring.

Open

class InfoRequest < ApplicationRecord
  OLD_AGE_IN_DAYS = 21.days

  include Rails.application.routes.url_helpers
  include AlaveteliPro::RequestSummaries

File acts_as_xapian.rb has 822 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'English'
begin
  require 'xapian'
  $acts_as_xapian_bindings_available = true

File public_body.rb has 723 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'csv'
require 'securerandom'
require 'set'
require 'confidence_intervals'

File routes.rb has 697 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'sidekiq/web'

include AlaveteliFeatures::Constraints

# Allow easy extension from themes. Note these will have the highest priority.

Class User has 72 methods (exceeds 20 allowed). Consider refactoring.

Open

class User < ApplicationRecord
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authentication
  include User::LoginToken

File request_controller.rb has 595 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'zip'

class RequestController < ApplicationController
  skip_before_action :html_response, only: [:show, :select_authorities]

Class PublicBody has 60 methods (exceeds 20 allowed). Consider refactoring.

Open

class PublicBody < ApplicationRecord
  include CalculatedHomePage
  include Categorisable
  include Taggable
  include Notable

File user.rb has 511 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class User < ApplicationRecord
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authentication
  include User::LoginToken

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  var submitAddForm = function submitAddForm(e) {
    e.preventDefault();
    var $this = $(this);
    DraftBatchSummary.startNewXHR();
    DraftBatchSummary.currentXHR = $.ajax({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  var submitRemoveForm = function submitRemoveForm(e) {
    e.preventDefault();
    var $this = $(this);
    DraftBatchSummary.startNewXHR();
    DraftBatchSummary.currentXHR = $.ajax({

• Read up
  Read up

Method get_language_name has 191 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def self.get_language_name(locale)
    language_names = {
      'ab'    => 'аҧсуа',
      'aa'    => 'Afaraf',
      'af'    => 'Afrikaans',

Function d3TimeSeries has 158 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function d3TimeSeries(selector, data, title, metric_name) {

  // Add the title
  var wrapper_element = document.querySelectorAll(selector)[0];

Method initialize has 147 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def initialize(user, project: nil, public_token: false)
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.is_admin?

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  DraftBatchSummary.bindXHR = function bindXHR() {
    DraftBatchSummary.currentXHR.done(function(data) {
      $el.trigger(Events.loadingSuccess, {html: data});
    });
    DraftBatchSummary.currentXHR.fail(function(xhr, textStatus) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  BatchAuthoritySearch.bindXHR = function bindXHR() {
    BatchAuthoritySearch.currentXHR.done(function(data) {
      $el.trigger(Events.loadingSuccess, {html: data});
    });
    BatchAuthoritySearch.currentXHR.fail(function(xhr, textStatus) {

• Read up
  Read up

Method world_foi_websites has 115 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def self.world_foi_websites
    world_foi_websites = [
      { name: "WhatDoTheyKnow",
        country_name: "United Kingdom",
        country_iso_code: "GB",

Method new has 104 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def new
    # All new requests are of normal_sort
    unless params[:outgoing_message].nil?
      params[:outgoing_message][:what_doing] = 'normal_sort'
    end

Function stripeForm has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function stripeForm(form, options) {
  var that = Object.assign({
    stripe: Stripe(AlaveteliPro.stripe_publishable_key),
    form: form,
    submit: document.getElementById('js-stripe-submit'),

Method search has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def search
    # TODO: Why is this so complicated with arrays and stuff? Look at the route
    # in config/routes.rb for comments.

    combined = params[:combined].split("/")