mysociety/alaveteli

View on GitHub

Showing 337 of 433 total issues

Method alert_tracks has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

  def self.alert_tracks
    done_something = false
    now = Time.zone.now
    one_week_ago = now - 7.days
    User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
Severity: Minor
Found in app/mailers/track_mailer.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  def new
    # All new requests are of normal_sort
    unless params[:outgoing_message].nil?
      params[:outgoing_message][:what_doing] = 'normal_sort'
    end
Severity: Minor
Found in app/controllers/request_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_csv_from_file has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

  def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
    errors = []
    notes = []
    begin
      ActiveRecord::Base.transaction do
Severity: Minor
Found in app/models/public_body.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize_query has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize_query(options)
      #raise options.to_yaml

      self.runtime += Benchmark.realtime {
        offset = options[:offset] || 0
Severity: Minor
Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File mail_backend.rb has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mail'
require 'mapi/msg'
require 'mapi/convert'
require 'config_helper'
require 'alaveteli_file_types'
Severity: Minor
Found in lib/mail_handler/backends/mail_backend.rb - About 5 hrs to fix

    File incoming_message.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'rexml/document'
    require 'zip'
    
    class IncomingMessage < ApplicationRecord
      include MessageProminence
    Severity: Minor
    Found in app/models/incoming_message.rb - About 5 hrs to fix

      Method search has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

        def search
          # TODO: Why is this so complicated with arrays and stuff? Look at the route
          # in config/routes.rb for comments.
      
          combined = params[:combined].split("/")
      Severity: Minor
      Found in app/controllers/general_controller.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class IncomingMessage has 37 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class IncomingMessage < ApplicationRecord
        include MessageProminence
        include CacheAttributesFromRawEmail
        include Taggable
      
      
      Severity: Minor
      Found in app/models/incoming_message.rb - About 4 hrs to fix

        Class ApplicationController has 37 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class ApplicationController < ActionController::Base
          class PermissionDenied < StandardError
          end
        
          class RouteNotFound < StandardError
        Severity: Minor
        Found in app/controllers/application_controller.rb - About 4 hrs to fix

          Method world_foi_websites has 115 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.world_foi_websites
              world_foi_websites = [
                { name: "WhatDoTheyKnow",
                  country_name: "United Kingdom",
                  country_iso_code: "GB",
          Severity: Major
          Found in lib/world_foi_websites.rb - About 4 hrs to fix

            Method permanently_failed_addresses has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

                def self.permanently_failed_addresses(message)
                  if MailHandler.empty_return_path?(message)
                    # Some sort of auto-response
            
                    # Check for Exim’s X-Failed-Recipients header
            Severity: Minor
            Found in lib/mail_handler/reply_handler.rb - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Class UserController has 34 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class UserController < ApplicationController
              include UserSpamCheck
            
              skip_before_action :html_response, only: [
                :show, :wall, :get_draft_profile_photo, :get_profile_photo
            Severity: Minor
            Found in app/controllers/user_controller.rb - About 4 hrs to fix

              Class InfoRequest has 33 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class InfoRequest
                module State
                  module Transitions
                    # Returns a label for the given state, suitable for using in a form to
                    # update the status of a request.
              Severity: Minor
              Found in app/models/info_request/state/transitions.rb - About 4 hrs to fix

                Class RequestController has 33 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class RequestController < ApplicationController
                  skip_before_action :html_response, only: [:show, :select_authorities]
                
                  before_action :check_read_only, only: [:new, :upload_response]
                  before_action :set_render_recaptcha, only: [ :new ]
                Severity: Minor
                Found in app/controllers/request_controller.rb - About 4 hrs to fix

                  Method new has 104 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def new
                      # All new requests are of normal_sort
                      unless params[:outgoing_message].nil?
                        params[:outgoing_message][:what_doing] = 'normal_sort'
                      end
                  Severity: Major
                  Found in app/controllers/request_controller.rb - About 4 hrs to fix

                    File application_controller.rb has 336 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    class ApplicationController < ActionController::Base
                      class PermissionDenied < StandardError
                      end
                    
                      class RouteNotFound < StandardError
                    Severity: Minor
                    Found in app/controllers/application_controller.rb - About 4 hrs to fix

                      Method signup has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def signup
                          # Make the user and try to save it
                          @user_signup = User.new(user_params(:user_signup))
                          error = false
                          if @request_from_foreign_country && !verify_recaptcha
                      Severity: Minor
                      Found in app/controllers/user_controller.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method clean_po has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def clean_po(input)
                            lines = input.split("\n")
                      
                            lines.each_with_index do |line, index|
                              match = /^msgid "(.*)"/.match(line)
                      Severity: Minor
                      Found in lib/alaveteli_gettext/fuzzy_cleaner.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
                            fixture_set_names = Array(fixture_set_names).map(&:to_s)
                            class_names = ClassCache.new class_names, config
                      
                            # FIXME: Apparently JK uses this.
                      Severity: Minor
                      Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function stripeForm has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function stripeForm(form, options) {
                        var that = Object.assign({
                          stripe: Stripe(AlaveteliPro.stripe_publishable_key),
                          form: form,
                          submit: document.getElementById('js-stripe-submit'),
                      Severity: Major
                      Found in app/assets/javascripts/alaveteli_pro/stripe.js - About 3 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language