mysociety/alaveteli

View on GitHub

Showing 507 of 1,317 total issues

Class User has 66 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ActiveRecord::Base
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authentication

Severity: Major
Found in app/models/user.rb - About 1 day to fix

    File routes.rb has 560 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    include AlaveteliFeatures::Constraints
    
    # Allow easy extension from themes. Note these will have the highest priority.
    $alaveteli_route_extensions.each do |f|
      load File.join('config', f)
    Severity: Major
    Found in config/routes.rb - About 1 day to fix

      Method table_rows has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
      Open

          def table_rows
            now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
            now = now.to_s(:db)
      
            # allow a standard key to be used for doing defaults in YAML
      Severity: Minor
      Found in lib/fixture_set_table_rows_patch.rb - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File admin_public_body_categories_controller_spec.rb has 521 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'spec_helper'
      
      describe AdminPublicBodyCategoriesController do
      
        describe 'GET index' do
      Severity: Major
      Found in spec/controllers/admin_public_body_categories_controller_spec.rb - About 1 day to fix

        Method xapian_index has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
        Open

            def xapian_index(terms = true, values = true, texts = true)
              # if we have a conditional function for indexing, call it and destroy object if failed
              if self.class.xapian_options.include?(:if)
                if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                if not if_value
        Severity: Minor
        Found in lib/acts_as_xapian/acts_as_xapian.rb - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File user_spam_scorer_spec.rb has 501 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
        
        describe UserSpamScorer do
        
          after(:each) { described_class.reset }
        Severity: Major
        Found in spec/lib/user_spam_scorer_spec.rb - About 1 day to fix

          Method alert_tracks has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.alert_tracks
              done_something = false
              now = Time.zone.now
              one_week_ago = now - 7.days
              User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
          Severity: Minor
          Found in app/mailers/track_mailer.rb - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_language_name has 191 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.get_language_name(locale)
              language_names = {
                'ab'    => 'аҧсуа',
                'aa'    => 'Afaraf',
                'af'    => 'Afrikaans',
          Severity: Major
          Found in lib/languages.rb - About 7 hrs to fix

            File user.rb has 484 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            class User < ActiveRecord::Base
              include AlaveteliFeatures::Helpers
              include AlaveteliPro::PhaseCounts
              include User::Authentication
            
            
            Severity: Minor
            Found in app/models/user.rb - About 7 hrs to fix

              Function drawSeriesLines has 187 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      function drawSeriesLines(series) {
                          function plotLine(datapoints, xoffset, yoffset, axisx, axisy) {
                              var points = datapoints.points,
                                  ps = datapoints.pointsize,
                                  prevx = null, prevy = null;
              Severity: Major
              Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

                File admin_public_body_headings_controller_spec.rb has 467 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'spec_helper'
                
                describe AdminPublicBodyHeadingsController do
                
                  describe 'GET new' do
                Severity: Minor
                Found in spec/controllers/admin_public_body_headings_controller_spec.rb - About 7 hrs to fix

                  File user_controller.rb has 466 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  require 'set'
                  
                  class UserController < ApplicationController
                    layout :select_layout
                    # NOTE: Rails 4 syntax: change before_filter to before_action
                  Severity: Minor
                  Found in app/controllers/user_controller.rb - About 7 hrs to fix

                    Function drawGrid has 177 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            function drawGrid() {
                                var i, axes, bw, bc;
                    
                                ctx.save();
                                ctx.translate(plotOffset.left, plotOffset.top);
                    Severity: Major
                    Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

                      File api_controller_spec.rb has 455 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                      
                      describe ApiController, "when using the API" do
                      
                        describe 'checking API keys' do
                      Severity: Minor
                      Found in spec/controllers/api_controller_spec.rb - About 6 hrs to fix

                        Class PublicBody has 49 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class PublicBody < ActiveRecord::Base
                          include AdminColumn
                        
                          class ImportCSVDryRun < StandardError ; end
                        
                        
                        Severity: Minor
                        Found in app/models/public_body.rb - About 6 hrs to fix

                          File mail_server_log_spec.rb has 451 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                          
                          describe MailServerLog do
                            describe ".load_file" do
                              before :each do
                          Severity: Minor
                          Found in spec/models/mail_server_log_spec.rb - About 6 hrs to fix

                            Method initialize has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def initialize(user)
                                # Define abilities for the passed in user here. For example:
                                #
                                #   user ||= User.new # guest user (not logged in)
                                #   if user.is_admin?
                            Severity: Minor
                            Found in app/models/ability.rb - About 6 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function processData has 167 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    function processData() {
                                        var topSentry = Number.POSITIVE_INFINITY,
                                            bottomSentry = Number.NEGATIVE_INFINITY,
                                            fakeInfinity = Number.MAX_VALUE,
                                            i, j, k, m, length,
                            Severity: Major
                            Found in app/assets/javascripts/jquery.flot.js - About 6 hrs to fix

                              File info_request_helper_spec.rb has 443 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                              
                              describe InfoRequestHelper do
                              
                                include InfoRequestHelper
                              Severity: Minor
                              Found in spec/helpers/info_request_helper_spec.rb - About 6 hrs to fix

                                Class InfoRequestEvent has 46 methods (exceeds 20 allowed). Consider refactoring.
                                Open

                                class InfoRequestEvent < ActiveRecord::Base
                                  include AdminColumn
                                  extend XapianQueries
                                
                                  EVENT_TYPES = [
                                Severity: Minor
                                Found in app/models/info_request_event.rb - About 6 hrs to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language