mysociety/alaveteli

View on GitHub

Showing 500 issues of 1,294 total

Class RequestController has 44 methods (exceeds 20 allowed). Consider refactoring.
Open

class RequestController < ApplicationController
  before_filter :check_read_only, :only => [ :new, :describe_state, :upload_response ]
  before_filter :check_batch_requests_and_user_allowed, :only => [ :select_authorities, :new_batch ]
  before_filter :set_render_recaptcha, :only => [ :new ]
  before_filter :redirect_numeric_id_to_url_title, :only => [:show]
Severity: Minor
Found in app/controllers/request_controller.rb - About 6 hrs to fix

    Class PublicBody has 44 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class PublicBody < ActiveRecord::Base
      include AdminColumn
    
      class ImportCSVDryRun < StandardError ; end
    
    
    Severity: Minor
    Found in app/models/public_body.rb - About 6 hrs to fix

      Method import_csv_from_file has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
          errors = []
          notes = []
          begin
            ActiveRecord::Base.transaction do
      Severity: Minor
      Found in app/models/public_body.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize(user)
          # Define abilities for the passed in user here. For example:
          #
          #   user ||= User.new # guest user (not logged in)
          #   if user.is_admin?
      Severity: Minor
      Found in app/models/ability.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File user_spam_scorer_spec.rb has 410 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
      
      describe UserSpamScorer do
      
        after(:each) { described_class.reset }
      Severity: Minor
      Found in spec/lib/user_spam_scorer_spec.rb - About 5 hrs to fix

        Class OutgoingMessage has 43 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class OutgoingMessage < ActiveRecord::Base
          include AdminColumn
          include MessageProminence
          include Rails.application.routes.url_helpers
          include LinkToHelper
        Severity: Minor
        Found in app/models/outgoing_message.rb - About 5 hrs to fix

          File info_request_event.rb has 407 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          class InfoRequestEvent < ActiveRecord::Base
            include AdminColumn
            extend XapianQueries
          
            EVENT_TYPES = [
          Severity: Minor
          Found in app/models/info_request_event.rb - About 5 hrs to fix

            Function setup has 141 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    setup: function() {
                        var self      = this;
                        var settings  = self.settings;
                        var eventNS   = self.eventNS;
                        var $window   = $(window);
            Severity: Major
            Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 5 hrs to fix

              File application_controller.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'open-uri'
              
              class ApplicationController < ActionController::Base
                class PermissionDenied < StandardError
                end
              Severity: Minor
              Found in app/controllers/application_controller.rb - About 5 hrs to fix

                File request_mailer.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                class RequestMailer < ApplicationMailer
                  include AlaveteliFeatures::Helpers
                
                  # Used when an FOI officer uploads a response from their web browser - this is
                  # the "fake" email used to store in the same format in the database as if they
                Severity: Minor
                Found in app/mailers/request_mailer.rb - About 5 hrs to fix

                  Class ApplicationController has 40 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class ApplicationController < ActionController::Base
                    class PermissionDenied < StandardError
                    end
                    class RouteNotFound < StandardError
                    end
                  Severity: Minor
                  Found in app/controllers/application_controller.rb - About 5 hrs to fix

                    File request_summary_spec.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require 'spec_helper'
                    
                    RSpec.describe AlaveteliPro::RequestSummary, type: :model do
                      let(:public_bodies) { FactoryGirl.create_list(:public_body, 3) }
                      let(:public_body_names) do
                    Severity: Minor
                    Found in spec/models/alaveteli_pro/request_summary_spec.rb - About 5 hrs to fix

                      Method list has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def list
                          long_cache
                          # TODO: move some of these tag SQL queries into has_tag_string.rb
                      
                          like_query = params[:public_body_query]
                      Severity: Minor
                      Found in app/controllers/public_body_controller.rb - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method up has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def up
                          default_locale = AlaveteliLocalization.default_locale
                      
                          fields = {:title => :text,
                                    :description => :text}
                      Severity: Minor
                      Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method initialize_query has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def initialize_query(options)
                            #raise options.to_yaml
                      
                            self.runtime += Benchmark::realtime {
                              offset = options[:offset] || 0; offset = offset.to_i
                      Severity: Minor
                      Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File transitions_spec.rb has 374 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require 'spec_helper'
                      
                      describe InfoRequest::State::Transitions do
                        let(:info_request) { FactoryGirl.create(:info_request) }
                      
                      
                      Severity: Minor
                      Found in spec/models/info_request/state/transitions_spec.rb - About 5 hrs to fix

                        File public_body_controller_spec.rb has 373 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                        
                        require 'nokogiri'
                        
                        describe PublicBodyController, "when showing a body" do
                        Severity: Minor
                        Found in spec/controllers/public_body_controller_spec.rb - About 4 hrs to fix

                          Method search has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def search
                              # TODO: Why is this so complicated with arrays and stuff? Look at the route
                              # in config/routes.rb for comments.
                          
                              # 404 if the request is a format we don't support (e.g:.json)
                          Severity: Minor
                          Found in app/controllers/general_controller.rb - About 4 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method permanently_failed_addresses has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def self.permanently_failed_addresses(message)
                                if MailHandler.empty_return_path?(message)
                                  # Some sort of auto-response
                          
                                  # Check for Exim’s X-Failed-Recipients header
                          Severity: Minor
                          Found in lib/mail_handler/reply_handler.rb - About 4 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function selectize has 118 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              $.fn.selectize = function(settings_user) {
                                  var defaults             = $.fn.selectize.defaults;
                                  var settings             = $.extend({}, defaults, settings_user);
                                  var attr_data            = settings.dataAttr;
                                  var field_label          = settings.labelField;
                          Severity: Major
                          Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 4 hrs to fix
                            Severity
                            Category
                            Status