mysociety/alaveteli

View on GitHub

Showing 500 of 1,294 total issues

Method new has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def new
    # All new requests are of normal_sort
    if !params[:outgoing_message].nil?
      params[:outgoing_message][:what_doing] = 'normal_sort'
    end
Severity: Minor
Found in app/controllers/request_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method list has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def list
    long_cache
    # TODO: move some of these tag SQL queries into has_tag_string.rb

    like_query = params[:public_body_query]
Severity: Major
Found in app/controllers/public_body_controller.rb - About 4 hrs to fix

    File followups_controller_spec.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
    
    describe FollowupsController do
      render_views
    
    
    Severity: Minor
    Found in spec/controllers/followups_controller_spec.rb - About 4 hrs to fix

      File outgoing_message.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class OutgoingMessage < ActiveRecord::Base
        include AdminColumn
        include MessageProminence
        include Rails.application.routes.url_helpers
        include LinkToHelper
      Severity: Minor
      Found in app/models/outgoing_message.rb - About 4 hrs to fix

        Function init has 110 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function init(plot) {
                // Taken from flot-axislabels.
                // This is kind of a hack. There are no hooks in Flot between
                // the creation and measuring of the ticks (setTicks, measureTickLabels
                // in setupGrid() ) and the drawing of the ticks and plot box
        Severity: Major
        Found in app/assets/javascripts/jquery.flot.tickrotor.js - About 4 hrs to fix

          Method world_foi_websites has 107 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.world_foi_websites
              world_foi_websites = [
                { :name => "WhatDoTheyKnow",
                  :country_name => "United Kingdom",
                  :country_iso_code => "GB",
          Severity: Major
          Found in lib/world_foi_websites.rb - About 4 hrs to fix

            File xapian_spec.rb has 343 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
            
            describe User, " when indexing users with Xapian" do
            
              before(:each) do
            Severity: Minor
            Found in spec/models/xapian_spec.rb - About 4 hrs to fix

              File jquery.flot.axislabels.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /*
              Axis Labels Plugin for flot.
              http://github.com/markrcote/flot-axislabels
              
              Original code is Copyright (c) 2010 Xuan Luo.
              Severity: Minor
              Found in app/assets/javascripts/jquery.flot.axislabels.js - About 4 hrs to fix

                File general_controller_spec.rb has 341 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                require 'fakeweb'
                
                describe GeneralController do
                
                
                Severity: Minor
                Found in spec/controllers/general_controller_spec.rb - About 4 hrs to fix

                  Class InfoRequest has 33 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class InfoRequest
                    module State
                      module Transitions
                        # Returns a label for the given state, suitable for using in a form to
                        # update the status of a request.
                  Severity: Minor
                  Found in app/models/info_request/state/transitions.rb - About 4 hrs to fix

                    File track_controller_spec.rb has 340 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                    
                    describe TrackController do
                      let(:mock_cookie) { '0300fd3e1177127cebff' }
                    
                    
                    Severity: Minor
                    Found in spec/controllers/track_controller_spec.rb - About 4 hrs to fix

                      File embargo_spec.rb has 335 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require 'spec_helper'
                      
                      describe AlaveteliPro::Embargo, :type => :model do
                        let(:embargo) { FactoryGirl.create(:embargo) }
                      
                      
                      Severity: Minor
                      Found in spec/models/alaveteli_pro/embargo_spec.rb - About 4 hrs to fix

                        Method search has 100 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          def search
                            # TODO: Why is this so complicated with arrays and stuff? Look at the route
                            # in config/routes.rb for comments.
                        
                            # 404 if the request is a format we don't support (e.g:.json)
                        Severity: Major
                        Found in app/controllers/general_controller.rb - About 4 hrs to fix

                          Class UserController has 32 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          class UserController < ApplicationController
                            layout :select_layout
                            # NOTE: Rails 4 syntax: change before_filter to before_action
                            before_filter :normalize_url_name, :only => :show
                            before_filter :work_out_post_redirect, :only => [ :signup ]
                          Severity: Minor
                          Found in app/controllers/user_controller.rb - About 4 hrs to fix

                            Function refreshOptions has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    refreshOptions: function(triggerDropdown) {
                                        var i, j, k, n, groups, groups_order, option, option_html, optgroup, optgroups, html, html_children, has_create_option;
                                        var $active, $active_before, $create;
                                
                                        if (typeof triggerDropdown === 'undefined') {
                            Severity: Major
                            Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 3 hrs to fix

                              File info_request_batch_spec.rb has 331 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              require 'spec_helper'
                              
                              describe InfoRequestBatch do
                                context "when validating" do
                                  let(:info_request_batch) { FactoryGirl.build(:info_request_batch) }
                              Severity: Minor
                              Found in spec/models/info_request_batch_spec.rb - About 3 hrs to fix

                                Method clean_po has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    def clean_po(input)
                                      lines = input.split("\n")
                                
                                      lines.each_with_index do |line, index|
                                        match = /^msgid "(.*)"/.match(line)
                                Severity: Minor
                                Found in lib/alaveteli_gettext/fuzzy_cleaner.rb - About 3 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function plotLineArea has 96 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                            function plotLineArea(datapoints, axisx, axisy) {
                                                var points = datapoints.points,
                                                    ps = datapoints.pointsize,
                                                    bottom = Math.min(Math.max(0, axisy.min), axisy.max),
                                                    i = 0, top, areaOpen = false,
                                Severity: Major
                                Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                                  Function setupTickGeneration has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                          function setupTickGeneration(axis) {
                                              var opts = axis.options;
                                  
                                              // estimate number of ticks
                                              var noTicks;
                                  Severity: Major
                                  Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                                    File admin_user_controller_spec.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
                                    Open

                                    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                                    
                                    describe AdminUserController do
                                    
                                      describe 'GET index' do
                                    Severity: Minor
                                    Found in spec/controllers/admin_user_controller_spec.rb - About 3 hrs to fix
                                      Severity
                                      Category
                                      Status
                                      Source